Skip to content

chore: move the signpost next to GDA header and remove default label#682

Merged
anguyen-yext2 merged 5 commits into
mainfrom
no-default-signpost-label
Jun 25, 2026
Merged

chore: move the signpost next to GDA header and remove default label#682
anguyen-yext2 merged 5 commits into
mainfrom
no-default-signpost-label

Conversation

@anguyen-yext2

@anguyen-yext2 anguyen-yext2 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Currently, the default GDA signpost seems redundant because the default GDA header is 'AI Generated Answer'. To address this, we're moving the signpost to the header row and removing the redundant label by default.

J=WAT-5664
TEST=manual,auto

Screen.Recording.2026-06-25.at.1.56.12.PM.mov

@anguyen-yext2 anguyen-yext2 requested a review from a team as a code owner June 24, 2026 20:01
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Current unit coverage is 89.2094861660079%
Current visual coverage is 69.06105695228322%
Current combined coverage is 91.66020170674942%

@coveralls

coveralls commented Jun 24, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 84.593% (+0.02%) from 84.578% — no-default-signpost-label into main

@mkouzel-yext

Copy link
Copy Markdown
Contributor

nit: can we make the default button behind the signpost icon square when the label is empty?

@anguyen-yext2

Copy link
Copy Markdown
Contributor Author

nit: can we make the default button behind the signpost icon square when the label is empty?

updated!

@mkouzel-yext mkouzel-yext left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anguyen-yext2 anguyen-yext2 merged commit 2903466 into main Jun 25, 2026
22 of 23 checks passed
@anguyen-yext2 anguyen-yext2 deleted the no-default-signpost-label branch June 25, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants