[K-005] core: _dataclass 헬퍼 중복 제거 (#287)#295
Merged
Merged
Conversation
_dataclass was defined identically in both core/capability.py and core/models.py. Canonicalize in capability.py (adding the pyright ignore comment from the models.py version) and import it into models.py, removing the now-unused dataclass/TypeVar/dataclass_transform imports. Closes #287
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
core/capability.py와core/models.py에_dataclass헬퍼 함수가 동일하게 두 벌 정의되어 있던 문제를 수정합니다.변경 내용
capability.py
_dataclass내부_decorate반환에# pyright: ignore[reportCallIssue]주석 추가 (models.py 버전과 통일)models.py
_dataclass함수 정의 제거capability.py에서_dataclassimport로 교체dataclasses.dataclass as _stdlib_dataclass,typing.TypeVar,typing_extensions.dataclass_transform,collections.abc.Callable검증
ruff check통과mypy통과pytest tests/unit/→ 766/766 통과Closes #287