[K-004] sgis: _extract_err_code 중복 제거 (#286)#294
Merged
Conversation
Move _extract_err_code to auth.py with the broader Mapping[str, object] signature (vs dict in auth, Mapping in adapter). adapter.py now imports it from auth.py, removing the identical copy. Closes #286
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
auth.py와adapter.py에 완전히 동일한_extract_err_code함수가 두 개 존재하던 문제를 수정합니다.변경 내용
auth.py의_extract_err_code시그니처를dict[str, object]→Mapping[str, object]으로 통일 (adapter.py 버전과 일치)auth.py에서collections.abc.Mappingimport 추가adapter.py에서_extract_err_code를auth.py로부터 importadapter.py의 중복 구현 제거검증
ruff check통과mypy통과pytest tests/unit/providers/sgis/→ 15/15 통과Closes #286