Skip to content

fix: remove schedule run counters during cleanup - #216

Merged
StekPerepolnen merged 2 commits into
ydb-platform:mainfrom
StekPerepolnen:fix-schedule-run-counter-cleanup
Nov 12, 2026
Merged

StekPerepolnen merged 2 commits into
ydb-platform:mainfrom
StekPerepolnen:fix-schedule-run-counter-cleanup

Conversation

@StekPerepolnen

@StekPerepolnen StekPerepolnen commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Deleting or disabling a backup schedule leaves schedules_failed_count and schedules_succeeded_count exposed by YDBCP. Add both counters to ResetScheduleCounters and extend the existing cleanup test.

@StekPerepolnen
StekPerepolnen force-pushed the fix-schedule-run-counter-cleanup branch from ec968be to 25fa203 Compare November 12, 2026 10:58
@StekPerepolnen
StekPerepolnen marked this pull request as ready for review November 12, 2026 11:34
@bma13
bma13 requested a balanced review from Copilot November 12, 2026 15:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the schedule-counter cleanup change.

No open issues 🎉

What changed in this PR

Fixes stale schedule run counters remaining exposed by YDBCP after a backup schedule is deleted or disabled.

Changes:

  • Removes failed and succeeded run-counter series for the matching schedule labels in ResetScheduleCounters.
  • Extends the cleanup test to verify both counters exist before reset and disappear afterward.
File Description
internal/​metrics/​metrics.go Deletes both schedule run-counter series during cleanup.
internal/​metrics/​metrics_test.go Seeds both counters and checks their presence before cleanup and absence afterward.

Review effort: Balanced

@StekPerepolnen
StekPerepolnen merged commit f557572 into ydb-platform:main Nov 12, 2026
5 checks passed
@StekPerepolnen
StekPerepolnen deleted the fix-schedule-run-counter-cleanup branch November 12, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants