Skip to content

Improve cli coverage, part 1 - #59963

Open
pnv1 wants to merge 2 commits into
ydb-platform:mainfrom
pnv1:improve-cli-coverage
Open

pnv1 wants to merge 2 commits into
ydb-platform:mainfrom
pnv1:improve-cli-coverage

Conversation

@pnv1

@pnv1 pnv1 commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Changelog entry

Description for reviewers

Extend CLI end-to-end coverage around table maintenance and schema inspection:

  • Copy independent table snapshots with and without indexes, checking data through both the table and its indexes. Exercise staged-table rollout and rollback through chained renames, including rejection of an accidental overwrite.
  • Export an ordered key range in projected pages, resume after the last exported key, and check an inclusive range with --count-only.
  • Inspect an indexed table's columns, TTL, partitioning settings and partition boundaries; inventory a mixed hierarchy of schema objects before recursive removal.
  • Exercise the permission lifecycle: grant, revoke, replace, change owner, toggle inheritance, list and clear local permissions. Check owners and explicit/effective ACLs alongside the existing table and folder backup/restore scenarios.

Reuse and consolidate existing scenarios to keep the total number of test cases unchanged. No product implementation changes.

Copilot AI balanced review requested due to automatic review settings November 18, 2026 20:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified in the expanded YDB CLI functional test coverage.

No open issues 🎉

What changed in this PR

This PR expands YDB CLI functional test coverage for table operations, schema inspection, and permission management without changing production code.

Changes:

  • Strengthens copy and rename tests with index reads, snapshot isolation checks, rollout, and rollback scenarios.
  • Adds bounded read pagination, row counting, partition descriptions, and recursive directory inventory checks.
  • Exercises permission commands and verifies explicit and inherited permissions before and after backup and restore.
File Description
ydb/​tests/​functional/​ydb_cli/​test_ydb_tools.py Tests mixed-index copies and rename rollout/rollback, validating data and indexes.
ydb/​tests/​functional/​ydb_cli/​test_ydb_table.py Adds bounded pagination and range-count assertions.
ydb/​tests/​functional/​ydb_cli/​test_ydb_scheme.py Checks indexed table schema, retention settings, statistics, and partition boundaries.
ydb/​tests/​functional/​ydb_cli/​test_ydb_recursive_remove.py Validates recursive JSON inventory and metadata before removal.
ydb/​tests/​functional/​ydb_cli/​test_ydb_backup.py Adds permission-command coverage and permission checks across backup and restore.

Review effort: Balanced

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

⚪ 2026-11-18 20:34:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2fbfad5 has started.
⚪ 2026-11-18 20:34:37 UTC Artifacts will be uploaded here
⚪ 2026-11-18 20:36:06 UTC ya make is running...
🟡 2026-11-18 20:42:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
974 971 0 1 2 0

⚪ 2026-11-18 20:42:12 UTC ya make is running... (failed tests rerun, try 2)
🟢 2026-11-18 20:43:00 UTC Tests successful.

Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6 (only retried tests) 6 0 0 0 0

🟢 2026-11-18 20:43:04 UTC Build successful.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants