Repository navigation
C++ SDK topic/ut: 64 partitions in ResetLatestAllPartitionsCommitted and cpu:4 under sanitizers - #59860
Open
sovetkinAA wants to merge 2 commits into
Open
C++ SDK topic/ut: 64 partitions in ResetLatestAllPartitionsCommitted and cpu:4 under sanitizers#59860sovetkinAA wants to merge 2 commits into
sovetkinAA wants to merge 2 commits into
Conversation
Contributor
|
Hi! Thank you for contributing! |
Contributor
|
⚪
🟢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog entry
Not for changelog (tests only).
Description for reviewers
TResetOffsetSdkTests::ResetLatestAllPartitionsCommitted(#54149) does not fit into the 3600 s LARGE timeout under ASan. It times out in every nightlyRegression-run_Largerelease-asan run since 06.11 (the test alone runs ~3300 s before its chunk is killed), and in the Arcadia heavy CI it fails in 149 of 183 runs since it was imported on 30.10. The test creates a topic with 1024 partitions and opens a separate write session for each of them. ResetOffset sends its requests to all partitions at once, without batching, so under a sanitizer the test now uses 64 partitions; builds without a sanitizer still use 1024.After #53703 and #57897 the suite has
REQUIREMENTS(cpu:1), taken from PR-check measurements, where the suite is MEDIUM and has no sanitizer. UnderSANITIZER_TYPEit is LARGE, and the Arcadia heavy CI runs it in a Sandbox task with exactly one core. On older hostsLocalPartition::WithoutPartitionWithRestartandBasicUsage::Producer_TimeoutErrorthen hit the 3600 s timeout too. The nightly ASan tests_metrics dashboard shows p95 2.7 cores per chunk for this suite (CPU tier cpu:4), so underSANITIZER_TYPEthe suite getscpu:4again, as before #53703. MEDIUM runs keepcpu:1.Checked in Arcadia (same files):
ya dump json-test-listgives the suite LARGE withcpu:4, ram:32under-DSANITIZER_TYPE=addressand MEDIUM withcpu:1, ram:32without it. In a release-asan build with the autocheck flags,ResetLatestAllPartitionsCommittedpasses in 16 s.cc @nshestakov @naspirato