Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The dump can fail during rolling upgrades because actual reads lack an unknown-pragma retry fallback, and the tests do not verify sorted-read requests during Dump() itself.
2 open issues
What changed in this PR
This PR updates ydb tools dump to use primary-key-ordered reads for column tables when the server supports OptEnableOlapSortedRead, reducing memory needed for sorting.
Changes:
- Probe and cache pragma support, retaining the previous read path when unsupported.
- Prefetch the next result part while serializing the current part.
- Add sorted-read, resume-query, and backup/restore tests, plus changelog entries.
| File | Description |
|---|---|
ydb/services/ydb/backup_ut/ydb_backup_ut.cpp |
Adds query-plan checks and a column-table dump/restore test. |
ydb/library/backup/ut/ut.cpp |
Tests unknown-pragma error detection. |
ydb/library/backup/backup.h |
Declares the pragma constant and compatibility helper. |
ydb/library/backup/backup.cpp |
Adds capability probing, pragma injection, and result prefetching. |
ydb/core/kqp/ut/olap/reading/sorted_read_ut.cpp |
Tests dump-shaped sorted reads and parameterized resume queries. |
ydb/apps/ydb/CHANGELOG.md |
Documents sorted reads and prefetching for column-table dumps. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
55dcae5 to
2726d8f
Compare
|
⚪ ⚪
🟢 |
| } | ||
|
|
||
| const auto issues = result.GetIssues().ToOneLineString(); | ||
| if (IsUnknownOlapSortedReadPragma(TStringBuf(issues.data(), issues.size()))) { |
There was a problem hiding this comment.
Проблемы с отступами
|
🔴 Unable to merge your PR into the base branch. Please rebase or merge it with the base branch. |

Changelog entry
...
Description for reviewers
Включаю OptEnableOlapSortedRead если она доступна на сервере. Позволяет с ограниченным объемом памяти зачитывать данные с сервера в сортированном виде