Skip to content

[stable-26-3-1-17-bridge] Backport Bridge CLI and storage fixes - #58411

Merged
mregrock merged 30 commits into
ydb-platform:stable-26-3-1-17-bridgefrom
mregrock:codex/bridge-followup-backport-20261106
Nov 6, 2026
Merged

mregrock merged 30 commits into
ydb-platform:stable-26-3-1-17-bridgefrom
mregrock:codex/bridge-followup-backport-20261106

Conversation

@mregrock

@mregrock mregrock commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Backport merged main fixes missing from stable-26-3-1-17-bridge: Bridge CLI controls, generation checks, storage recovery, SchemeBoard synchronization and NodeWarden lifecycle fixes.

Deployment precondition for #57702 is confirmed: the target cluster has never run Bridge. The existing six-column BSC schema therefore follows the upstream supported upgrade path. For other deployments, this PR still does not migrate an already persisted seven-column PDisk-filter table.

Requested PRs included: #56555, #56801, #57702, #58162, #55651, #57638, #57882, #57950, #58006, #58183.

Additional merged fixes found by checking the issues and replacement PRs:

Branch adaptations preserve the older PDisk service factory and configuration APIs, add the necessary VDisk incarnation fence from main, register tests in the existing Bridge layout, and update branch-specific canonical results. Only generic hidden-command parser support from #55802 is included as a dependency of #57638. The pool descriptor erase and existing ReadStoragePool regression assertions from #54949 are included as the prerequisite for #57702 delete/recreate coverage; other virtual-group changes from that PR are excluded.

No documentation/changelogs, generated embedded UI, new mirror-3-dc two-DC mode, Skipper or ydbd-mock changes. The common phantom-only fix from #55651 includes the existing basic mirror-3-dc strategy; hunks for the separate new strategy are excluded.

Validation:

  • Full ydbd relwithdebinfo build and targeted regressions: 20 suites, 267 checks passed (266 tests and flake8), including real Bridge database-mode/discovery requests, storage recovery, pool deletion/recreation, and both canonical targets.
  • Focused PDisk/VDisk lifetime checks under AddressSanitizer: 5 tests passed.
  • SDK Bridge connectivity: 4 tests passed with -Werror.
  • Release CLI build and command-help smoke checks passed; hidden-command parser passed 33 standalone checks.
  • Final functional/independent cleanliness review accounted for all 122/122 files; immutable snapshot verified fresh.

The final focused run excludes the pre-existing exhaustive Replication.Phantoms_* fixtures already muted in the Bridge base. The new offline-datacenter phantom scenarios from #55651 are included and passed.

Built revision: 84c10d3cca228e0fbb2fe81e33475ff099fb8c85, release compatibility 26.3.1.17.0. The binary is labelled stable-26-3-1-17-bridge+backport; it is an unreleased patch build, not an official Git release tag.

alexvru and others added 26 commits November 6, 2026 09:25
…atform#57882)

Co-authored-by: Cursor <cursoragent@cursor.com>
(cherry picked from commit 24afd18)
…tform#57950)

Co-authored-by: Cursor <cursoragent@cursor.com>
(cherry picked from commit af7239f)
…ate (ydb-platform#58006)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit fb15342)
Select only the generic parser/registration support from fa89267 (ydb-platform#55802). Keep deprecated pool set-bridge-mode callable while omitting it from help, as required by ydb-platform#57638. No cluster reanimate or other command changes.
@mregrock
mregrock marked this pull request as ready for review November 6, 2026 10:03
@mregrock
mregrock requested a review from a team as a code owner November 6, 2026 10:03
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

⚪ 2026-11-06 10:03:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0292059 has started.
⚪ 2026-11-06 10:03:30 UTC Artifacts will be uploaded here
⚪ 2026-11-06 10:04:44 UTC ya make is running...
⚫ 2026-11-06 10:10:42 UTC Check cancelled

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

⚪ 2026-11-06 10:15:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for e02b697 has started.
⚪ 2026-11-06 10:15:56 UTC Artifacts will be uploaded here
⚪ 2026-11-06 10:17:12 UTC ya make is running...
⚫ 2026-11-06 11:09:35 UTC Check cancelled

Select the descriptor erase and existing ReadStoragePool regression assertions from upstream 88b88db (ydb-platform#54949). The Bridge group snapshot/unbinding path is already present. This enables the actual delete/recreate contract tested by ydb-platform#57702 without importing unrelated virtual-group changes.
Match the main PDisk subsystem fixture using the existing Bridge service factory. Preserve device-release delay assertions while preventing unintended Undelivered replies.
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

⚪ 2026-11-06 11:12:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 327e462 has started.
⚪ 2026-11-06 11:12:35 UTC Artifacts will be uploaded here
⚪ 2026-11-06 11:13:52 UTC ya make is running...
🟡 2026-11-06 12:43:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
33146 33054 0 5 81 6

⚪ 2026-11-06 12:43:19 UTC ya make is running... (failed tests rerun, try 2)
🟡 2026-11-06 13:08:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
148 (only retried tests) 146 0 1 0 1

⚪ 2026-11-06 13:08:21 UTC ya make is running... (failed tests rerun, try 3)
🟢 2026-11-06 13:17:29 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3 (only retried tests) 2 0 0 0 1

🟢 2026-11-06 13:17:31 UTC Build successful.
🟡 2026-11-06 13:17:57 UTC ydbd size 2.6 GiB changed* by +1.2 MiB, which is >= 100.0 KiB vs stable-26-3-1-17-bridge: Warning

ydbd size dash stable-26-3-1-17-bridge: d99db86 merge: 327e462 diff diff %
ydbd size 2 833 257 512 Bytes 2 834 477 840 Bytes +1.2 MiB +0.043%
ydbd stripped size 589 841 304 Bytes 590 048 888 Bytes +202.7 KiB +0.035%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@mregrock
mregrock merged commit bc6cb0b into ydb-platform:stable-26-3-1-17-bridge Nov 6, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants