Skip to content

[stable-26-3-1-17-bridge] Backport Bridge server correctness fixes - #58091

Merged
mregrock merged 5 commits into
ydb-platform:stable-26-3-1-17-bridgefrom
mregrock:codex/backport-bridge-wiki-20261104
Nov 4, 2026
Merged

mregrock merged 5 commits into
ydb-platform:stable-26-3-1-17-bridgefrom
mregrock:codex/backport-bridge-wiki-20261104

Conversation

@mregrock

@mregrock mregrock commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Changelog entry

Fix Bridge storage request routing, synchronization and decommissioning; validate pool conversion; fix StateStorage recovery and subscriptions used by the Bridge control plane.

Changelog category

  • Bugfix

Description for reviewers

Backport Bridge server correctness fixes to stable-26-3-1-17-bridge, with their regression tests and required stable-API adaptations. The patch contains 44 production/build files and 35 test files.

Base: ab40de3534bf9780c06207a816439208a898ea81.

Validation (Linux, relwithdebinfo, C++20):

  • Combined build of ydbd and all selected test binaries passed.
  • Both reported canonical failures pass: dstool Test.test_essential and tablet schema flat_bs_controller, using unchanged base canondata.
  • The new Block commit-LSN regression fails on the old bool code. With the narrow ui64 correction, all 11 Block race and Bridge Block-quorum tests pass.
  • Bridge/DSProxy strategies and proxy/NodeWarden: 621 tests passed across 4 suites.
  • StateStorage/Board/configuration validation/long transactions/SchemeBoard/HealthCheck: 327 tests passed across 6 suites.
  • Functional follower recovery passed all 3 repeats. Its fixture lets the normal follower-pipe cache refresh before pausing the leader; the 5-second stale-read deadline is retained and tablet ChangeTime is checked to rule out restarts.
  • Dynamic-node startup-location recovery now restarts the whole test node, including its interconnect sessions, before replacing its keeper. All 207 NodeRole tests passed all 10 repeats.
  • Final scope review: accounted 79/79, reviewed 79, excluded 0; independent scope/cleanliness review completed.

The original follower test passed on main 51dbd27, but the same main reproduces the stale-read timeout when EnableColumnStatistics is disabled, matching this branch's default. The additional statistics table otherwise changes tablet placement and leaves the reader with a different initial resolver cache. The fixture now waits for the normal follower-pipe cache refresh and verifies unchanged tablet incarnations before pausing the leader, so the regression exercises follower availability across either configuration.

Full repository CI is pending.

Source changes and selected scope
Source PR Change Backported scope
#51375 Preserve the full VDisk Block commit LSN Narrow LSN-width correction and regression coverage
#50739 Support encryption in Interpile put optimization Interpile encryption prerequisite for batched Put deadlines
#57106 Restore blob from parts read when too many disks are not replicated yet Server fix and regression tests
#57382 Fix StateStorage self-heal event lifetime before Send Server fix and regression tests
#57624 Update StateStorage validation test expectations StateStorage regression-test compatibility/registration
#57584 Bridge proxy fixes from bridge review Server fix and regression tests
#57583 DSProxy fixes from bridge review Server fix and regression tests
#57582 BlobDepot fixes from bridge review Server fix and regression tests
#57581 BSC: stamp newly allocated bridge groups with their cluster state Server fix and regression tests
#57580 Bridge syncer fixes from bridge review Server fix and regression tests
#57585 NodeWarden fixes from bridge review Server fix and regression tests
#57273 State storage: count the ring being replaced in the self-heal quorum check Server fix and regression tests
#57326 StateStorage: register the scopes of Board subscription events Server fix and regression tests
#57648 DSProxy: arm the queue watchdog for pending assimilations Server fix and regression tests
#57764 Enable core/base tests in open-source builds StateStorage regression-test compatibility/registration
#57771 core/base/ya.make: remove IF OPENSOURCE StateStorage regression-test compatibility/registration
#57696 Throttle snapshot exchanger Board subscription retries Server fix and regression tests
#57705 Bridge proxy: charge only queued time to the routing wait Server fix and regression tests
#57706 BlobDepot: bound decommission Resolve by the requesting query's deadline Server fix and regression tests
#57731 Notify Board subscribers about empty-payload additions Server fix and regression tests
#57426 Allow StateStorage node reassignment in ring groups Server fix and regression tests
#57411 Preserve SchemeBoard publication cookies on reconnect Server fix and regression tests
#57130 Bridge stage 2 selfcheck Server HealthCheck and regression tests
#57329 StateStorage: register a replica guardian over a matching leader record Server fix and regression tests
#57279 State storage: decide on self-heal of each subsystem by its own replacements Server fix and regression tests
#57923 Fix race on StaticVDiskSlain Server fix and regression tests
#57949 Add validation for storage pool conversion Server fix and regression tests
#57973 StateStorage: clear missing replica after follower registration Server fix and regression tests

Base: ab40de3
Main snapshot: 78fb704

Source PRs and commits:
- ydb-platform#50739: de6302e
- ydb-platform#50928: c02ef43
- ydb-platform#56080: b38f096
- ydb-platform#56194: 2437f77
- ydb-platform#56283: 5d4aca2
- ydb-platform#55937: f6fc1a0
- ydb-platform#56332: 260e640
- ydb-platform#56370: 6d0b089
- ydb-platform#56151: 1f1cdd3
- ydb-platform#56653: 60cfc3a
- ydb-platform#56680: 5b28582
- ydb-platform#56729: 31d516e
- ydb-platform#56783: 09e3b20
- ydb-platform#56862: e73d636
- ydb-platform#57008: cdb0166
- ydb-platform#56799: 32b9cce
- ydb-platform#57106: bb41149
- ydb-platform#57096: 10b38e9
- ydb-platform#57047: 2a6988c
- ydb-platform#57197: d67371e
- ydb-platform#57196: 0731b96
- ydb-platform#57363: 9e652f5
- ydb-platform#57343: ccc86f3
- ydb-platform#57382: d84341c
- ydb-platform#57402: 948d31c
- ydb-platform#57319: 07db320
- ydb-platform#57624: 79f08e3
- ydb-platform#57584: 8b9fe8e
- ydb-platform#57583: a70e7e5
- ydb-platform#57582: eca4f3d
- ydb-platform#57128: e0bc7d0
- ydb-platform#57581: 09e4c55
- ydb-platform#57580: f1f924a
- ydb-platform#57585: de5b564
- ydb-platform#57273: b5a8279
- ydb-platform#57326: 40cfafb
- ydb-platform#57674: c5c6b6b
- ydb-platform#57648: 0bf9d6d
- ydb-platform#57730: 19a8b90
- ydb-platform#57729: 478b0a5
- ydb-platform#57531: 4c2ef9d
- ydb-platform#57764: a762d01
- ydb-platform#57406: a63405d
- ydb-platform#57771: c335598
- ydb-platform#57696: 33a4084
- ydb-platform#57705: 877453d
- ydb-platform#57706: f0448ef
- ydb-platform#57823: 0130cef
- ydb-platform#57810: 5968b07
- ydb-platform#57731: 4d5b358
- ydb-platform#57426: 43a2496
- ydb-platform#57411: 6c21ff8
- ydb-platform#57638: 7f447d8
- ydb-platform#57130: c006a66
- ydb-platform#57329: 28b6ba4
- ydb-platform#57279: 99e26bf
- ydb-platform#57923: a7df2b8
- ydb-platform#57878: 35d01a7
- ydb-platform#57833: 6b2afc6
- ydb-platform#57949: b97b49c
- ydb-platform#57973: fc82aed

Additional source backports:
- ydb-platform#57184: narrow VDisk LSN-width correction
- ydb-platform/ydb-python-sdk#934: async session-pool capacity recovery
- ydb-platform/ydb-embedded-ui#4530, ydb-platform#4541, ydb-platform#4533, ydb-platform#4523
  UI source: 44af1bfeabafe3dbaa832c0f17b51afba6851746

Stable configuration/protocol/test APIs and existing CLI aliases are retained.
Storage pool filters retain their persisted seven-column key.
@mregrock
mregrock requested a review from a team as a code owner November 3, 2026 22:58
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

⚪ 2026-11-03 23:01:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for fc82a9e has started.
⚪ 2026-11-03 23:01:43 UTC Artifacts will be uploaded here
⚪ 2026-11-03 23:02:59 UTC ya make is running...
🟡 2026-11-04 01:18:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
33692 33601 0 3 81 7

⚪ 2026-11-04 01:18:11 UTC ya make is running... (failed tests rerun, try 2)
🟡 2026-11-04 01:22:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77 (only retried tests) 74 0 2 0 1

⚪ 2026-11-04 01:22:18 UTC ya make is running... (failed tests rerun, try 3)
🔴 2026-11-04 01:23:07 UTC Some tests failed, follow the links below.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5 (only retried tests) 2 0 2 0 1

🟢 2026-11-04 01:23:10 UTC Build successful.
🔴 2026-11-04 01:23:33 UTC ydbd size 2.6 GiB changed* by +2.0 MiB, which is >= 2.0 MiB vs stable-26-3-1-17-bridge: Alert

ydbd size dash stable-26-3-1-17-bridge: ab40de3 merge: fc82a9e diff diff %
ydbd size 2 832 973 272 Bytes 2 835 112 880 Bytes +2.0 MiB +0.076%
ydbd stripped size 589 803 736 Bytes 590 162 840 Bytes +350.7 KiB +0.061%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

✅ Documentation build

Revision built successfully
Revision preview link

@mregrock
mregrock marked this pull request as draft November 4, 2026 09:22
@mregrock mregrock changed the title [stable-26-3-1-17-bridge] Backport outstanding merged Bridge fixes [stable-26-3-1-17-bridge] Backport Bridge server correctness fixes Nov 4, 2026
@github-actions github-actions Bot removed the documentation Improvements or additions to documentation label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

⚪ 2026-11-04 10:09:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for a5b8e90 has started.
⚪ 2026-11-04 10:09:15 UTC Artifacts will be uploaded here
⚪ 2026-11-04 10:10:32 UTC ya make is running...
⚫ 2026-11-04 11:39:00 UTC Check cancelled

@mregrock
mregrock marked this pull request as ready for review November 4, 2026 10:43
Backport the LSN-width correction from ydb-platform#51375 with the regression from ydb-platform#57184.
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

⚪ 2026-11-04 11:40:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for d9012cd has started.
⚪ 2026-11-04 11:43:09 UTC Artifacts will be uploaded here
⚪ 2026-11-04 11:44:39 UTC ya make is running...
🟡 2026-11-04 13:10:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31750 31655 0 4 81 10

⚪ 2026-11-04 13:10:37 UTC ya make is running... (failed tests rerun, try 2)
🟡 2026-11-04 13:12:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
233 (only retried tests) 229 0 1 2 1

⚪ 2026-11-04 13:12:20 UTC ya make is running... (failed tests rerun, try 3)
🔴 2026-11-04 13:12:59 UTC Some tests failed, follow the links below.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12 (only retried tests) 10 0 1 0 1

🟢 2026-11-04 13:13:02 UTC Build successful.
🟡 2026-11-04 13:13:30 UTC ydbd size 2.6 GiB changed* by +277.6 KiB, which is >= 100.0 KiB vs stable-26-3-1-17-bridge: Warning

ydbd size dash stable-26-3-1-17-bridge: ab40de3 merge: d9012cd diff diff %
ydbd size 2 832 973 272 Bytes 2 833 257 512 Bytes +277.6 KiB +0.010%
ydbd stripped size 589 803 736 Bytes 589 841 304 Bytes +36.7 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

⚪ 2026-11-04 16:22:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9cf2d13 has started.
⚪ 2026-11-04 16:23:18 UTC Artifacts will be uploaded here
⚪ 2026-11-04 16:24:39 UTC ya make is running...
🟡 2026-11-04 16:57:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31750 31656 0 3 81 10

⚪ 2026-11-04 16:57:50 UTC ya make is running... (failed tests rerun, try 2)
🟢 2026-11-04 17:00:32 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
222 (only retried tests) 219 0 0 2 1

🟢 2026-11-04 17:00:35 UTC Build successful.
🟡 2026-11-04 17:00:55 UTC ydbd size 2.6 GiB changed* by +277.6 KiB, which is >= 100.0 KiB vs stable-26-3-1-17-bridge: Warning

ydbd size dash stable-26-3-1-17-bridge: ab40de3 merge: 9cf2d13 diff diff %
ydbd size 2 832 973 272 Bytes 2 833 257 512 Bytes +277.6 KiB +0.010%
ydbd stripped size 589 803 736 Bytes 589 841 304 Bytes +36.7 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@mregrock
mregrock enabled auto-merge (squash) November 4, 2026 17:50
@mregrock
mregrock merged commit d99db86 into ydb-platform:stable-26-3-1-17-bridge Nov 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants