Repository navigation
Document JSON parameters in JSON index predicates - #57476
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
⚪
🟢 |
✅ Documentation buildRevision built successfully |
There was a problem hiding this comment.
AI Review Summary
Verdict: ✅ No critical issues found
Critical issues
No critical issues found.
Other findings
- Major | Medium: The feature is documented only in the Russian docs; the English counterparts (
ydb/docs/en/core/recipes/json-search/json-index-parameters.md,ydb/docs/en/core/dev/json-indexes.md,ydb/docs/en/core/yql/reference/syntax/select/json_index.md) still list only scalar parameter types and contain noJson-parameter section, so RU and EN now contradict each other —ydb/docs/ru/core/recipes/json-search/json-index-parameters.md:144 - Minor | High: The documented
Json-parameter feature silently fails when combined withERROR ON EMPTY/ERROR ON ERRORclauses ("JSON index cannot preserve ERROR ON EMPTY/ERROR semantics for Json parameters", seeydb/core/kqp/opt/logical/kqp_opt_log_json_index.cpp:28and the check at line 556), but none of the three edited pages mention this limitation —ydb/docs/ru/core/dev/json-indexes.md:134 - Minor | Medium: The new "Пересечение JSON-массивов" section describes only documents 1–3 while the prepared dataset now contains 4 documents; document 4 with its empty
tagsarray (the very case the section's closing sentence talks about) is not mentioned —ydb/docs/ru/core/recipes/json-search/json-index-parameters.md:92 - Minor | Medium: The new section demonstrates
PASSINGbefore the section that introduces it ("Параметры внутри JsonPath (PASSING)" comes next), and the intro list "Типичные варианты использования" (items 1–3) was not extended with the fourth use case —ydb/docs/ru/core/recipes/json-search/json-index-parameters.md:90 - Nit | High: Type naming in the updated list (
String,Utf8) now differs from the equivalent lists in the dev doc and the English docs, which useBytes(String),Text(Utf8) —ydb/docs/ru/core/recipes/json-search/json-index-parameters.md:144 - Nit | High: The added example in the "Поддерживаемые предикаты" section introduces a full query with
payloadanddocuments VIEW json_idx, while all surrounding examples in that section use a baredoccolumn without table context —ydb/docs/ru/core/dev/json-indexes.md:120
The documented behavior itself was verified against the implementation (IsSupportedJsonParamType / ParseAndCollectJson in ydb/core/kqp/opt/logical/kqp_opt_log_json_index.cpp) and is covered by the JSON-index corpus tests under ydb/core/kqp/ut/indexes/json/ (including the empty-array and ERROR-clause cases), so the claims about OR-token expansion, no duplicate rows, and empty result for an empty array are accurate.
This review was generated automatically. Critical issues require attention; other findings are advisory.
If this comment was useful, please give it a 👍 — it helps us improve the review bot.
|
Analysis performed by claude, z-ai/glm-5.3-flash. |
|
⚪
🟢 |
✅ Documentation buildRevision built successfully |
✅ Documentation buildRevision built successfully |
|
⚪
🟢 |
|
Перевод должен быть бекпортнут в следующие стабильные ветки: 26.4.1 |
|
Backported to |
|
Перевод этого PR: #59972 |
Changelog entry
Add Russian documentation for JSON parameters in JSON index predicates, including array intersection examples.
For #54120