Skip to content

Document JSON parameters in JSON index predicates - #57476

Merged
sintjuri merged 3 commits into
ydb-platform:mainfrom
dahbka-lis:ji-json-params
Nov 18, 2026
Merged

sintjuri merged 3 commits into
ydb-platform:mainfrom
dahbka-lis:ji-json-params

Conversation

@dahbka-lis

@dahbka-lis dahbka-lis commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Changelog entry

Add Russian documentation for JSON parameters in JSON index predicates, including array intersection examples.

For #54120

Copilot AI balanced review requested due to automatic review settings October 29, 2026 13:01
@dahbka-lis
dahbka-lis requested a review from a team as a code owner October 29, 2026 13:01
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Oct 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

⚪ 2026-10-29 13:06:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 761b6f4 has started.
⚪ 2026-10-29 13:06:28 UTC Artifacts will be uploaded here
⚪ 2026-10-29 13:07:58 UTC ya make is running...
🟢 2026-10-29 13:47:26 UTC Tests successful.

Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1329 1327 0 0 2 0

🟢 2026-10-29 13:47:30 UTC Build successful.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Documentation build

Revision built successfully
Revision preview link

@robot-vibe-db robot-vibe-db Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Review Summary

Verdict: ✅ No critical issues found

Critical issues

No critical issues found.

Other findings

  • Major | Medium: The feature is documented only in the Russian docs; the English counterparts (ydb/docs/en/core/recipes/json-search/json-index-parameters.md, ydb/docs/en/core/dev/json-indexes.md, ydb/docs/en/core/yql/reference/syntax/select/json_index.md) still list only scalar parameter types and contain no Json-parameter section, so RU and EN now contradict each other — ydb/docs/ru/core/recipes/json-search/json-index-parameters.md:144
  • Minor | High: The documented Json-parameter feature silently fails when combined with ERROR ON EMPTY / ERROR ON ERROR clauses ("JSON index cannot preserve ERROR ON EMPTY/ERROR semantics for Json parameters", see ydb/core/kqp/opt/logical/kqp_opt_log_json_index.cpp:28 and the check at line 556), but none of the three edited pages mention this limitation — ydb/docs/ru/core/dev/json-indexes.md:134
  • Minor | Medium: The new "Пересечение JSON-массивов" section describes only documents 1–3 while the prepared dataset now contains 4 documents; document 4 with its empty tags array (the very case the section's closing sentence talks about) is not mentioned — ydb/docs/ru/core/recipes/json-search/json-index-parameters.md:92
  • Minor | Medium: The new section demonstrates PASSING before the section that introduces it ("Параметры внутри JsonPath (PASSING)" comes next), and the intro list "Типичные варианты использования" (items 1–3) was not extended with the fourth use case — ydb/docs/ru/core/recipes/json-search/json-index-parameters.md:90
  • Nit | High: Type naming in the updated list (String, Utf8) now differs from the equivalent lists in the dev doc and the English docs, which use Bytes (String), Text (Utf8) — ydb/docs/ru/core/recipes/json-search/json-index-parameters.md:144
  • Nit | High: The added example in the "Поддерживаемые предикаты" section introduces a full query with payload and documents VIEW json_idx, while all surrounding examples in that section use a bare doc column without table context — ydb/docs/ru/core/dev/json-indexes.md:120

The documented behavior itself was verified against the implementation (IsSupportedJsonParamType / ParseAndCollectJson in ydb/core/kqp/opt/logical/kqp_opt_log_json_index.cpp) and is covered by the JSON-index corpus tests under ydb/core/kqp/ut/indexes/json/ (including the empty-array and ERROR-clause cases), so the claims about OR-token expansion, no duplicate rows, and empty result for an empty array are accurate.


This review was generated automatically. Critical issues require attention; other findings are advisory.
If this comment was useful, please give it a 👍 — it helps us improve the review bot.

Comment thread ydb/docs/ru/core/dev/json-indexes.md Resolved
Comment thread ydb/docs/ru/core/dev/json-indexes.md Resolved
@robot-vibe-db

robot-vibe-db Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Full analysis log

Analysis performed by claude, z-ai/glm-5.3-flash.

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

⚪ 2026-11-02 12:41:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for f01d61a has started.
⚪ 2026-11-02 12:41:36 UTC Artifacts will be uploaded here
⚪ 2026-11-02 12:43:04 UTC ya make is running...
🟢 2026-11-02 12:48:36 UTC Tests successful.

Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1329 1327 0 0 2 0

🟢 2026-11-02 12:48:41 UTC Build successful.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

✅ Documentation build

Revision built successfully
Revision preview link

@sintjuri
sintjuri requested a review from spuchin November 5, 2026 06:02
Comment thread ydb/docs/ru/core/dev/json-indexes.md Resolved
@dahbka-lis
dahbka-lis requested review from a team as code owners November 9, 2026 09:16
@dahbka-lis
dahbka-lis requested review from spuchin and removed request for a team, Alek5andr-Kotov, ijon and pixcc November 9, 2026 09:22
@dahbka-lis
dahbka-lis marked this pull request as ready for review November 9, 2026 09:22
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

⚪ 2026-11-09 09:40:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for b46eb34 has started.
⚪ 2026-11-09 09:41:20 UTC Artifacts will be uploaded here
⚪ 2026-11-09 09:42:51 UTC ya make is running...
🟢 2026-11-09 09:48:40 UTC Tests successful.

Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1368 1366 0 0 2 0

🟢 2026-11-09 09:48:44 UTC Build successful.

@sintjuri
sintjuri merged commit 70c348f into ydb-platform:main Nov 18, 2026
16 checks passed
@ydbot

ydbot commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

Backport

To backport this PR, click the button next to the target branch and then click "Run workflow" in the Run Actions UI.

Branch Run
stable-26-3-1, stable-26-4-1 ▶  Backport
stable-26-4-1 ▶  Backport

▶  Backport manual

@sintjuri sintjuri added the doc_translate Translate documentation label Nov 18, 2026
@sintjuri

Copy link
Copy Markdown
Contributor

Перевод должен быть бекпортнут в следующие стабильные ветки: 26.4.1

@github-actions github-actions Bot removed the doc_translate Translate documentation label Nov 18, 2026
@ydbot

ydbot commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Backported to stable-26-4-1: PR #59973 - workflow run

@github-actions

Copy link
Copy Markdown
Contributor

Перевод этого PR: #59972

@github-actions github-actions Bot mentioned this pull request Nov 18, 2026
ydbot added a commit that referenced this pull request Nov 19, 2026
sintjuri pushed a commit that referenced this pull request Nov 19, 2026
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai_reviewed documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants