Skip to content

CLI: preserve HTTPS scheme in YT export proxies - #57102

Merged
weres-sa merged 2 commits into
dev/weres-sa/yt-export-https-testfrom
dev/weres-sa/yt-export-https-fix
Nov 18, 2026
Merged

weres-sa merged 2 commits into
dev/weres-sa/yt-export-https-testfrom
dev/weres-sa/yt-export-https-fix

Conversation

@weres-sa

@weres-sa weres-sa commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

ydb export yt --proxy https://<proxy> currently fails before contacting YDB because ParseYtProxy treats the colon in the URI scheme as a port separator. Changing only the port to 443 also leaves the host without an HTTPS scheme for server-side discovery.

Preserve explicit HTTP/HTTPS schemes in the Export API host, default HTTPS to port 443, and honor explicit ports. Keep legacy host and short cluster-name handling. Reject URL paths, queries, fragments and userinfo rather than passing malformed proxy addresses to the server. Update command help and the CLI changelog.

Stacked on #57101, which adds the regression tests. This PR targets its test branch, so its diff contains only the fix, help and changelog. The test-only PR is intentionally expected to fail until this fix is applied; merge this PR into that branch before merging the combined change into main.

Validation target: ydb/public/lib/ydb_cli/common/ut, filter YtProxyParsing::*. Targeted Linux CI: https://github.com/ydb-platform/ydb/actions/runs/40554819610 (fixed tree). The test-only control run is https://github.com/ydb-platform/ydb/actions/runs/40554793453. These tests parse synthetic arguments and do not contact a cluster.

Changelog entry

  • Fixed HTTP/HTTPS proxy parsing for ydb export yt; HTTPS defaults to port 443.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Run-tests started

  • Build Preset: relwithdebinfo
  • Test Size: small
  • Test Targets: ydb/public/lib/ydb_cli/common/ut
  • Commit: eed92f5
  • Workflow run: link

⚪ 2026-10-27 17:55:41 UTC Artifacts will be uploaded here
⚪ 2026-10-27 17:56:04 UTC ya make is running...
🟢 2026-10-27 17:57:02 UTC Tests successful.

Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10 10 0 0 0 0

🟢 2026-10-27 17:57:07 UTC Build successful.

Comment thread ydb/apps/ydb/CHANGELOG.md Outdated
@@ -1,3 +1,4 @@
* Fixed `ydb export yt --proxy` rejecting HTTP/HTTPS URLs; HTTPS proxies now default to port 443 and preserve the scheme for server-side proxy discovery.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Команда ydb export yt нет в opensource CLI, запись в opensource changelog не нужна

@weres-sa
weres-sa merged commit 2aadcec into dev/weres-sa/yt-export-https-test Nov 18, 2026
1 of 2 checks passed
@weres-sa
weres-sa deleted the dev/weres-sa/yt-export-https-fix branch November 18, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants