Repository navigation
Conversation
Contributor
Run-tests started
⚪
🟢 |
pnv1
reviewed
Oct 28, 2026
| @@ -1,3 +1,4 @@ | |||
| * Fixed `ydb export yt --proxy` rejecting HTTP/HTTPS URLs; HTTPS proxies now default to port 443 and preserve the scheme for server-side proxy discovery. | |||
Contributor
There was a problem hiding this comment.
Команда ydb export yt нет в opensource CLI, запись в opensource changelog не нужна
weres-sa
merged commit Nov 18, 2026
2aadcec
into
dev/weres-sa/yt-export-https-test
1 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ydb export yt --proxy https://<proxy>currently fails before contacting YDB becauseParseYtProxytreats the colon in the URI scheme as a port separator. Changing only the port to 443 also leaves the host without an HTTPS scheme for server-side discovery.Preserve explicit HTTP/HTTPS schemes in the Export API host, default HTTPS to port 443, and honor explicit ports. Keep legacy host and short cluster-name handling. Reject URL paths, queries, fragments and userinfo rather than passing malformed proxy addresses to the server. Update command help and the CLI changelog.
Stacked on #57101, which adds the regression tests. This PR targets its test branch, so its diff contains only the fix, help and changelog. The test-only PR is intentionally expected to fail until this fix is applied; merge this PR into that branch before merging the combined change into main.
Validation target:
ydb/public/lib/ydb_cli/common/ut, filterYtProxyParsing::*. Targeted Linux CI: https://github.com/ydb-platform/ydb/actions/runs/40554819610 (fixed tree). The test-only control run is https://github.com/ydb-platform/ydb/actions/runs/40554793453. These tests parse synthetic arguments and do not contact a cluster.Changelog entry
ydb export yt; HTTPS defaults to port 443.