Skip to content

Decouple C++ patch coverage checks from Codecov processing - #57012

Merged
pnv1 merged 2 commits into
ydb-platform:mainfrom
pnv1:stabilize-codecov-3
Oct 29, 2026
Merged

pnv1 merged 2 commits into
ydb-platform:mainfrom
pnv1:stabilize-codecov-3

Conversation

@pnv1

@pnv1 pnv1 commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Changelog entry

...

Description for reviewers

Calculate C++ patch coverage directly from the original PR diff and the exact uploaded LCOV, so delayed Codecov processing or an unavailable main baseline no longer cause the check to fail. Keep main baseline availability informational and define patch coverage thresholds once in .github/codecov.yml for both Codecov and the local check.

@pnv1
pnv1 requested a review from a team as a code owner October 27, 2026 08:20
Copilot AI balanced review requested due to automatic review settings October 27, 2026 08:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

⚪ 2026-10-27 08:21:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for bc4ff17 has started.
⚪ 2026-10-27 08:23:08 UTC Artifacts will be uploaded here
⚪ 2026-10-27 08:25:10 UTC ya make is running...
🟢 2026-10-27 08:25:20 UTC Tests successful.

Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2026-10-27 08:25:24 UTC Build successful.

@pnv1 pnv1 changed the title Stabilize codecov 3 Decouple C++ patch coverage checks from Codecov processing Oct 27, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pnv1
pnv1 merged commit dc6bab8 into ydb-platform:main Oct 29, 2026
15 checks passed
@pnv1
pnv1 deleted the stabilize-codecov-3 branch October 29, 2026 07:10
@ydbot

ydbot commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator

Backport

To backport this PR, click the button next to the target branch and then click "Run workflow" in the Run Actions UI.

Branch Run
stable-26-3-1, stable-26-4-1 ▶  Backport
stable-26-4-1 ▶  Backport

▶  Backport manual

abyss7 added a commit to abyss7/ydb that referenced this pull request Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants