Repository navigation
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
kungasc
left a comment
There was a problem hiding this comment.
Documentation is required
c344298 to
d2e86b9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
| TVector<IWorkloadQueryGenerator::TWorkloadType> TKvWorkloadGenerator::GetSupportedWorkloadTypes() const { | ||
| TVector<TWorkloadType> result; | ||
| result.emplace_back(static_cast<int>(EType::UpsertRandom), "upsert", "Upsert random rows into table"); | ||
| result.emplace_back(static_cast<int>(EType::UpsertSequential), "upsert-seq", "Upsert sequential rows into table"); |
There was a problem hiding this comment.
назвал бы тогда уж полно флаг upsert-sequential
This comment was marked as outdated.
This comment was marked as outdated.
| result[row].Ints[col] = val; | ||
| } else { | ||
| TString val; | ||
| if (col < Params.KeyColumnsCnt) { |
There was a problem hiding this comment.
Тут бы сделать режим с аналогичным GenerateRandomRows(bool randomValues), чтобы буквы случайные генерились
There was a problem hiding this comment.
Я бы на самом деле и вообще бы выкинул без букв, с ними удобнее смотреть чем со странной строчкой, которая ещё и сжимается lz4 зачем-то
There was a problem hiding this comment.
Было бы странно сделать это только для GenerateSequentialRows().
Если избавляться от пререндеренной BigString в пользу случайных текстовых строк, то наверно унифицированно для всего TKvWorkloadGenerator'а.
Но в этом pr это не совсем по теме.
✅ Documentation buildRevision built successfully |
Co-authored-by: Ivan Blinkov <ivan@blinkov.ru>
2441546 to
c4f0f93
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
c4f0f93 to
d6743c9
Compare
✅ Documentation buildRevision built successfully |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
✅ Documentation buildRevision built successfully |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
|
||
| This load test runs several types of load: | ||
| * [upsert](#upsert-kv): Using the UPSERT operation, inserts rows that are tuples (key1, key2, ... keyK, value1, value2, ... valueN) into the table created previously with the init command, the K and N numbers are specified in the settings. | ||
| * [upsert-seq](#upsert-seq-kv): variant of upsert load, but inserts rows by sequential keys. |
There was a problem hiding this comment.
| * [upsert-seq](#upsert-seq-kv): variant of upsert load, but inserts rows by sequential keys. | |
| * [upsert-seq](#upsert-seq-kv): a variant of the upsert load that inserts rows with sequential keys. |
| ## Upsert-seq load {#upsert-seq-kv} | ||
|
|
||
| Upsert load variant for inserting rows by sequential keys instead of random. | ||
|
|
||
| Sequential upserts generate a concentrated load on a small number of table partitions (at each point in time) instead of creating a uniform load on the entire table. |
There was a problem hiding this comment.
| ## Upsert-seq load {#upsert-seq-kv} | |
| Upsert load variant for inserting rows by sequential keys instead of random. | |
| Sequential upserts generate a concentrated load on a small number of table partitions (at each point in time) instead of creating a uniform load on the entire table. | |
| ## Upsert-seq load {#upsert-seq-kv} | |
| An upsert load variant that inserts rows using sequential keys instead of random keys. | |
| Sequential upserts concentrate the load on a small number of table partitions at any given time rather than distributing it uniformly across the entire table. |
| * `global workload options`: [The global options for all load types](#global-workload-options). | ||
| * `specific workload options`: [Options of a specific load type](#upsert-seq-options). |
There was a problem hiding this comment.
| * `global workload options`: [The global options for all load types](#global-workload-options). | |
| * `specific workload options`: [Options of a specific load type](#upsert-seq-options). | |
| * `global workload options`: [global options for all load types](#global-workload-options). | |
| * `specific workload options`: [options for this specific load type](#upsert-seq-options). |
| ### Parameters for upsert {#upsert-seq-options} | ||
|
|
||
| Parameter name | Parameter description | ||
| ---|--- | ||
| `--len` | The size of the rows in bytes inserted into the table as values. Default: 8. | ||
| `--start-first-key` | The starting value for the primary key's first column. Default: 0. |
There was a problem hiding this comment.
| ### Parameters for upsert {#upsert-seq-options} | |
| Parameter name | Parameter description | |
| ---|--- | |
| `--len` | The size of the rows in bytes inserted into the table as values. Default: 8. | |
| `--start-first-key` | The starting value for the primary key's first column. Default: 0. | |
| ### Parameters for upsert-seq {#upsert-seq-options} | |
| Parameter name | Parameter description | |
| ---|--- | |
| `--len` | The size of the rows, in bytes, inserted into the table as values. Default: 8. | |
| `--start-first-key` | The starting value for the primary key's first column. Default: 0. |
| Имя параметра | Описание параметра | ||
| ---|--- | ||
| `--len` | Размер строк в байтах, которые вставляются в таблицу, как values. Значение по умолчанию: 8. | ||
| `--start-first-key` | Начальное значение первого компонента primary ключа. Значение по умолчанию: 0. |
There was a problem hiding this comment.
| `--start-first-key` | Начальное значение первого компонента primary ключа. Значение по умолчанию: 0. | |
| `--start-first-key` | Начальное значение первого компонента первичного ключа. Значение по умолчанию: 0. |
Changelog category
Additional information
Add
upsert-seqworkload type forydb workload kv runcommand.upsert-seqmakes upserts on the sequentially increasing keys -- special mode needed to induce (together with specific auto partitioning settings) table datashard splitting (by size).