Skip to content

rename event scope namespaces from TEv... to NEv... - #10835

Open
ijon wants to merge 2 commits into
ydb-platform:mainfrom
ijon:event-namespaces-rename
Open

ijon wants to merge 2 commits into
ydb-platform:mainfrom
ijon:event-namespaces-rename

Conversation

@ijon

@ijon ijon commented Oct 24, 2024 •

Copy link
Copy Markdown
Contributor

Stacked on #10685 -- change some event scopes from struct to namespace.

Rename previously changed scopes from TEv... to NEv....

Scopes changed:

  • NEvBlobDepot
  • NEvBlockStore
  • NEvColumnShard
  • NEvConfigsDispatcher
  • NEvConsole
  • NEvDataShard
  • NEvFileStore
  • NEvHive
  • NEvKesus
  • NEvPersQueue
  • NEvSchemeShard
  • NEvSequenceShard
  • NEvSubDomain

This is part of "improve schemeshard operation build-time" effort (#10633).

Changelog category

  • Not for changelog

@github-actions

github-actions Bot commented Oct 24, 2024 •

Copy link
Copy Markdown
Contributor

⚪ 2024-10-24 11:45:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for 421a167 has started.
⚪ 2024-10-24 11:45:34 UTC Artifacts will be uploaded here
⚪ 2024-10-24 11:48:45 UTC ya make is running...
🟡 2024-10-24 13:08:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41604 35980 0 4 5520 100

⚪ 2024-10-24 13:12:27 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-24 13:24:10 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
118 (only retried tests) 25 0 0 0 93

🟢 2024-10-24 13:24:17 UTC Build successful.
🟢 2024-10-24 13:24:37 UTC ydbd size 2.8 GiB changed* by -5.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 76efe46 merge: 421a167 diff diff %
ydbd size 3 032 440 840 Bytes 3 032 435 352 Bytes -5.4 KiB -0.000%
ydbd stripped size 480 963 128 Bytes 480 962 616 Bytes -512 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ijon ijon changed the title Event namespaces rename rename event scope namespaces from TEv... to NEv.... Oct 24, 2024
@github-actions

github-actions Bot commented Oct 24, 2024 •

Copy link
Copy Markdown
Contributor

⚪ 2024-10-24 11:46:01 UTC Pre-commit check linux-x86_64-release-asan for 421a167 has started.
⚪ 2024-10-24 11:46:36 UTC Artifacts will be uploaded here
⚪ 2024-10-24 11:50:20 UTC ya make is running...
🟡 2024-10-24 13:24:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11686 11499 0 42 43 102

🟢 2024-10-24 13:25:42 UTC Build successful.
🟢 2024-10-24 13:26:16 UTC ydbd size 5.7 GiB changed* by -9.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 76efe46 merge: 421a167 diff diff %
ydbd size 6 135 181 936 Bytes 6 135 172 664 Bytes -9.1 KiB -0.000%
ydbd stripped size 1 531 700 304 Bytes 1 531 697 744 Bytes -2.5 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ijon ijon mentioned this pull request Oct 24, 2024
12 of 28 tasks
@ijon ijon changed the title rename event scope namespaces from TEv... to NEv.... rename event scope namespaces from TEv... to NEv... Oct 24, 2024
@ijon
ijon marked this pull request as ready for review October 24, 2024 19:07
@ijon
ijon requested review from a team as code owners October 24, 2024 19:07
@ijon
ijon requested a review from Alek5andr-Kotov October 24, 2024 19:07
uzhastik
uzhastik previously approved these changes Oct 24, 2024
That requre changing event definition scopes from `struct` to `namespace`.
@ijon
ijon force-pushed the event-namespaces-rename branch 2 times, most recently from f940761 to 8cebf1f Compare October 28, 2024 14:57
@ydb-platform ydb-platform deleted a comment from github-actions Bot Oct 28, 2024
@ydb-platform ydb-platform deleted a comment from github-actions Bot Oct 28, 2024
@ijon
ijon force-pushed the event-namespaces-rename branch from 8cebf1f to 3f0aa9f Compare October 28, 2024 15:46
@ydb-platform ydb-platform deleted a comment from github-actions Bot Oct 28, 2024
@ydb-platform ydb-platform deleted a comment from github-actions Bot Oct 28, 2024
@github-actions

github-actions Bot commented Oct 28, 2024 •

Copy link
Copy Markdown
Contributor

⚪ 2024-10-28 15:48:57 UTC Pre-commit check linux-x86_64-release-asan for 8ae39ba has started.
⚪ 2024-10-28 15:49:01 UTC Artifacts will be uploaded here
⚪ 2024-10-28 15:52:14 UTC ya make is running...
🟡 2024-10-28 17:04:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10876 10712 0 43 25 96

🟢 2024-10-28 17:05:52 UTC Build successful.
🟢 2024-10-28 17:06:24 UTC ydbd size 5.7 GiB changed* by -13.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: d4eaec4 merge: 8ae39ba diff diff %
ydbd size 6 139 704 984 Bytes 6 139 691 624 Bytes -13.0 KiB -0.000%
ydbd stripped size 1 532 094 704 Bytes 1 532 088 048 Bytes -6.5 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions

github-actions Bot commented Oct 28, 2024 •

Copy link
Copy Markdown
Contributor

⚪ 2024-10-28 15:49:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8ae39ba has started.
⚪ 2024-10-28 15:49:55 UTC Artifacts will be uploaded here
⚪ 2024-10-28 15:53:10 UTC ya make is running...
🟡 2024-10-28 16:53:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41647 36004 0 4 5539 100

⚪ 2024-10-28 16:56:52 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-28 17:08:11 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
101 (only retried tests) 8 0 0 0 93

🟢 2024-10-28 17:08:19 UTC Build successful.
🟢 2024-10-28 17:08:39 UTC ydbd size 2.8 GiB changed* by -5.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: d4eaec4 merge: 8ae39ba diff diff %
ydbd size 3 033 914 584 Bytes 3 033 909 032 Bytes -5.4 KiB -0.000%
ydbd stripped size 480 680 664 Bytes 480 680 088 Bytes -576 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ijon
ijon requested a review from CyberROFL October 28, 2024 16:01
@CyberROFL
CyberROFL removed their request for review November 12, 2026 22:20
@sintjuri sintjuri added the documentation Improvements or additions to documentation label Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation not-for-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants