Skip to content

Add Topic Writer buffer byte gauges - #752

Merged
alex268 merged 2 commits into
masterfrom
topic-writer-buffer-bytes
Oct 9, 2026
Merged

alex268 merged 2 commits into
masterfrom
topic-writer-buffer-bytes

Conversation

@KirillKurdyukov

Copy link
Copy Markdown
Collaborator

Что меняется

Две gauges бюджета Topic Writer в одном PR:

  • ydb.topic.writer.buffer.used.bytes, By — занятый бюджет существующего limiter, включая округление reservations.
  • ydb.topic.writer.buffer.limit.bytes, By — настроенный лимит.

Имена, units и descriptions буквально совпадают с C# SDK. Gauges принадлежат WriterMetrics, регистрируются один раз на Writer и удаляются при terminal close; reconnect сохраняет регистрацию. Нет новых счётчиков бюджета, locks или изменений admission/ACK.

Проверка

Ровно один новый happy-path тест: init, отправка тел2+3 байта, used5/limit100, ACK и used0, cleanup.

mvn -B -pl topic -am -Dtest=OpenTelemetryMeterTest,WriterImplTest,WriterQueueTest,BufferManagerTest -Dsurefire.failIfNoSpecifiedTests=false clean package —51 tests,0 failures/errors/skips, Checkstyle0.
Direct JUnitCore WriterImplTest/WriterQueueTest/BufferManagerTest —37 tests.
Финальный code gate: APPROVE. Свежий локальный LSP недоступен из-за сбоя daemon; compiler/Checkstyle/tests проходят.

Задача: https://st.yandex-team.ru/YDBAPPTEAM-2115
Корневая задача: https://st.yandex-team.ru/YDB-3479

@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.29%. Comparing base (bd6d7ba) to head (df2f243).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #752      +/-   ##
============================================
+ Coverage     75.06%   75.29%   +0.23%     
- Complexity     3694     3717      +23     
============================================
  Files           395      395              
  Lines         16662    16716      +54     
  Branches       1760     1760              
============================================
+ Hits          12507    12587      +80     
+ Misses         3535     3518      -17     
+ Partials        620      611       -9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alex268
alex268 merged commit 464e525 into master Oct 9, 2026
16 checks passed
@alex268
alex268 deleted the topic-writer-buffer-bytes branch October 9, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants