Repository navigation
Add Topic Writer buffer byte gauges - #752
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #752 +/- ##
============================================
+ Coverage 75.06% 75.29% +0.23%
- Complexity 3694 3717 +23
============================================
Files 395 395
Lines 16662 16716 +54
Branches 1760 1760
============================================
+ Hits 12507 12587 +80
+ Misses 3535 3518 -17
+ Partials 620 611 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alex268
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что меняется
Две gauges бюджета Topic Writer в одном PR:
ydb.topic.writer.buffer.used.bytes,By— занятый бюджет существующего limiter, включая округление reservations.ydb.topic.writer.buffer.limit.bytes,By— настроенный лимит.Имена, units и descriptions буквально совпадают с C# SDK. Gauges принадлежат WriterMetrics, регистрируются один раз на Writer и удаляются при terminal close; reconnect сохраняет регистрацию. Нет новых счётчиков бюджета, locks или изменений admission/ACK.
Проверка
Ровно один новый happy-path тест: init, отправка тел2+3 байта, used5/limit100, ACK и used0, cleanup.
mvn -B -pl topic -am -Dtest=OpenTelemetryMeterTest,WriterImplTest,WriterQueueTest,BufferManagerTest -Dsurefire.failIfNoSpecifiedTests=false clean package—51 tests,0 failures/errors/skips, Checkstyle0.Direct JUnitCore WriterImplTest/WriterQueueTest/BufferManagerTest —37 tests.
Финальный code gate: APPROVE. Свежий локальный LSP недоступен из-за сбоя daemon; compiler/Checkstyle/tests проходят.
Задача: https://st.yandex-team.ru/YDBAPPTEAM-2115
Корневая задача: https://st.yandex-team.ru/YDB-3479