[Filestore] [6/N] Add resize retry and tablet restart coverage for sharded filestores by Maximus5 · Pull Request #7256 · ydb-platform/nbs

Maximus5 · 2026-09-21T16:12:08Z

Notes

Main issue: [Filestore] Send requests to SchemeShard in batches for CreateFileStore, ResizeFileStore, and DestroyFileStore #6310
Design doc: [Filestore] [1/N] Document the filestore resize flow in legacy and throttled modes #6376

Add an end-to-end test for throttled sharded filestore resize under concurrent retry and tablet restart.

The test waits until resize persists partial shard creation progress, starts an overlapping retry, restarts the tablet, and then verifies that resize can complete and the final topology is correct. This covers the recovery path that relies on persisted shard creation state rather than reissuing already completed shard creates.

The test recipe is moved to a medium setup with tablet restarts enabled, and shard management throttling is set to one request in flight to make partial progress deterministic.

Stack

github-actions · 2026-09-21T16:29:47Z

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/ (test time: 273s): all tests PASSED for commit 0dba4bd.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
1580	1580	0	0	0	0	0

🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 323s): all tests PASSED for commit 0dba4bd.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
1746	1746	0	0	0	0	0

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1397s): all tests PASSED for commit 0dba4bd.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
7574	7573	0	0	0	1	0

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 4594s): all tests PASSED for commit 0dba4bd.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
5054	5053	0	0	0	1	0

github-actions · 2026-09-24T15:19:13Z

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/,cloud/fastshard/ (test time: 278s): all tests PASSED for commit 53d6418.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
1671	1671	0	0	0	0	0

🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 317s): all tests PASSED for commit 53d6418.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
1746	1746	0	0	0	0	0

🔴 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1613s): some tests FAILED for commit 53d6418.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
7427	7417	0	9	0	1	0

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 954s): all tests PASSED for commit 53d6418.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
7436	7435	0	0	0	1	0

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 4773s): all tests PASSED for commit 53d6418.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
4830	4828	0	0	0	2	0

github-actions · 2026-09-30T16:46:31Z

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/,cloud/fastshard/ (test time: 278s): all tests PASSED for commit d45deac.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
1718	1718	0	0	0	0	0

🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 326s): all tests PASSED for commit d45deac.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
1755	1755	0	0	0	0	0

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1534s): all tests PASSED for commit d45deac.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
7493	7492	0	0	0	1	0

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 5364s): all tests PASSED for commit d45deac.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
4920	4919	0	0	0	1	0

github-actions · 2026-10-01T08:23:59Z

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/,cloud/fastshard/ (test time: 271s): all tests PASSED for commit f9be66c.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
1718	1718	0	0	0	0	0

🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 312s): all tests PASSED for commit f9be66c.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
1755	1755	0	0	0	0	0

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1389s): all tests PASSED for commit f9be66c.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
7494	7493	0	0	0	1	0

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 5201s): all tests PASSED for commit f9be66c.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
4922	4921	0	0	0	1	0

…filestores

github-actions · 2026-10-21T18:36:42Z

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/,cloud/fastshard/ (test time: 279s): all tests PASSED for commit 0379190.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
1806	1806	0	0	0	0	0

🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 301s): all tests PASSED for commit 0379190.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
1849	1849	0	0	0	0	0

🔴 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1537s): some tests FAILED for commit 0379190.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
7683	7681	0	1	0	1	0

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 991s): all tests PASSED for commit 0379190.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
7689	7688	0	0	0	1	0

🔴 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 5461s) Test run completed, no test results found for commit 0379190.
Please check build logs.

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 5200s): all tests PASSED for commit 0379190.

TESTS	PASSED	ERRORS	FAILED	FAILED BUILD	SKIPPED	MUTED^?
5079	5078	0	0	0	1	0

SvartMetal · 2026-10-23T12:50:50Z

+    resize_future,
+):
+    deadline = monotonic() + 60
+    while monotonic() < deadline:


Maybe use this function?

nbs/cloud/filestore/tests/lease_expiration/test.py

Line 390 in e0ef26e

assert wait_for(

SvartMetal · 2026-10-23T12:53:51Z

+
+SET(
+    NFS_STORAGE_CONFIG_PATCH
+    cloud/filestore/tests/client_sharded_dir_resize_retry/nfs-storage.txt


Maybe use newfeatures config?

https://github.com/ydb-platform/nbs/blob/main/cloud/filestore/tests/common_configs/nfs-storage-newfeatures-patch.txt

Maximus5 added this pull request to stack #7257 September 21, 2026 16:12

Maximus5 added the recheck Add this label to relaunch checks, it will be automatically removed label Sep 21, 2026

github-actions Bot removed the recheck Add this label to relaunch checks, it will be automatically removed label Sep 21, 2026

Maximus5 force-pushed the users/maximus5/filestore-resize-persist-state-int-tests branch from 0dba4bd to 53d6418 Compare September 24, 2026 15:17

Maximus5 added the recheck Add this label to relaunch checks, it will be automatically removed label Sep 24, 2026

github-actions Bot removed the recheck Add this label to relaunch checks, it will be automatically removed label Sep 24, 2026

Maximus5 force-pushed the users/maximus5/filestore-resize-persist-state-int-tests branch from 53d6418 to d45deac Compare September 30, 2026 16:44

Maximus5 added the recheck Add this label to relaunch checks, it will be automatically removed label Sep 30, 2026

github-actions Bot removed the recheck Add this label to relaunch checks, it will be automatically removed label Sep 30, 2026

Maximus5 force-pushed the users/maximus5/filestore-resize-persist-state-int-tests branch 2 times, most recently from 5e8c6cd to f9be66c Compare October 1, 2026 08:22

Maximus5 added the recheck Add this label to relaunch checks, it will be automatically removed label Oct 1, 2026

github-actions Bot removed the recheck Add this label to relaunch checks, it will be automatically removed label Oct 1, 2026

[Filestore] Add resize retry and tablet restart coverage for sharded …

0379190

…filestores

Maximus5 force-pushed the users/maximus5/filestore-resize-persist-state-int-tests branch from f9be66c to 0379190 Compare October 21, 2026 18:35

Maximus5 added the recheck Add this label to relaunch checks, it will be automatically removed label Oct 21, 2026

github-actions Bot removed the recheck Add this label to relaunch checks, it will be automatically removed label Oct 21, 2026

SvartMetal reviewed Oct 23, 2026

View reviewed changes

SvartMetal requested changes Oct 23, 2026

View reviewed changes

Navigation Menu

Repository navigation

[Filestore] [6/N] Add resize retry and tablet restart coverage for sharded filestores - #7256

[Filestore] [6/N] Add resize retry and tablet restart coverage for sharded filestores#7256
Maximus5 wants to merge 1 commit into
users/maximus5/filestore-resize-persist-state-use-statefrom
users/maximus5/filestore-resize-persist-state-int-tests

Maximus5 commented Sep 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 24, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 1, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 21, 2026 •

edited

Loading

Uh oh!

SvartMetal Oct 23, 2026

Uh oh!

SvartMetal Oct 23, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Maximus5 commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notes

Stack

Uh oh!

github-actions Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SvartMetal Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

SvartMetal Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Maximus5 commented Sep 21, 2026 •

edited

Loading

github-actions Bot commented Sep 21, 2026 •

edited

Loading

github-actions Bot commented Sep 24, 2026 •

edited

Loading

github-actions Bot commented Sep 30, 2026 •

edited

Loading

github-actions Bot commented Oct 1, 2026 •

edited

Loading

github-actions Bot commented Oct 21, 2026 •

edited

Loading