[gigeresk]

#339 added a version lock to hishel<2.0 because hishel 2.0 was released today and this breaks githubkit installation. This PR attempts to update the source to reflect hishel's 2.0 API changes.

[yanyongyu]

I'd consider this a new feature adding support for hishel v2, rather than a githubkit installation fix.

[gigeresk]

@yanyongyu sure, the fix is here #339. All that to say, currently installation from pypi is broken.

uv run --isolated --no-project --with githubkit python -c "import githubkit; print('ok')"
# workaround:
uv run --isolated --no-project --with githubkit --with 'hishel<2' python -c "import githubkit; print('ok')"

[mgkvibez]

Reviewing this as a migration checklist, since I checked the new signature directly:

CacheTransport(next_transport, storage: BaseStorage | None = None, rfc: bool | CacheOptions = False)
AsyncCacheTransport(next_transport, storage: AsyncBaseStorage | None = None, rfc: bool | CacheOptions = False)

The CachePolicy → rfc/CacheOptions mapping and the SyncSqliteStorage → SqliteStorage rename both look right, and keeping AsyncBaseStorage in the annotation is correct, it still exists in 2.0.

One thing I would change before this lands:

The default flipped from None to True, which is not parity. Previously kwargs.pop("policy", None) meant "no policy"; now kwargs.pop("policy", True) goes into rfc, and rfc=True opts the transport into RFC-9111 heuristic freshness, so responses carrying validators can be served from cache where they previously would not have been. hishel's own default for rfc is False. If the intent is to preserve existing behaviour, False is the value matching the old None and hishel's default; if True is deliberate, it deserves a changelog line, because it silently changes caching for everyone who never passed policy.

Two smaller notes:

1. The public kwarg keeps the name policy but changes type from CachePolicy | None to CacheOptions | bool. A caller passing a CachePolicy object now gets a TypeError at transport construction rather than something readable, so a line in the migration notes would save someone ten minutes.
2. GitHub reports the PR as non-mergeable against master right now, most likely uv.lock. A rebase would let CI reflect the actual merge result.

If it is useful, I can test the caching path against a real conditional request, since the default question is the only part I cannot settle from the diff alone.