Skip to content

fix: reject profile stdin double reads - #634

Merged
yakew7 merged 1 commit into
yakew7:mainfrom
Rayan-and-beyond:fix/profile-stdin-double-read-615
Sep 14, 2026
Merged

yakew7 merged 1 commit into
yakew7:mainfrom
Rayan-and-beyond:fix/profile-stdin-double-read-615

Conversation

@Rayan-and-beyond

Copy link
Copy Markdown
Contributor

Fixes #615.

Summary

  • reject profile - --reference - before stdin is consumed twice
  • reject a --proxy-hints-with=-=COLUMN input when the primary profile input is also stdin
  • keep the existing malformed PATH=COLUMN validation unchanged

Validation

  • both new regressions failed on main and pass with the guard
  • tests/test_cli.py: 49 passed / 19 skipped
  • available full suite: 292 passed / 41 skipped via python -m pytest tests/ (optional extras not installed are skipped)
  • em-dash check, internal-link check, Ruff, and git diff --check pass
  • both real CLI repros now return clear stdin-collision errors instead of a downstream empty-parse failure

@vercel

vercel Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@Rayan-and-beyond is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown

@yakew7 @ahmdkaml - new PR touching a path you own, please review.

@yakew7
yakew7 merged commit 1ff4043 into yakew7:main Sep 14, 2026
17 of 18 checks passed
yakew7 added a commit that referenced this pull request Sep 14, 2026
Adds 4 new contributors (Rayan-and-beyond, ege-arhan, KingEmma7,
Voyagerroc-Lab), notes ege-arhan's unlinked commit email in the Git
identity map (same pattern as Ayaan/Tanish/raonishanth2000-hub),
updates the Contributions-by-area table, and bumps the snapshot line
to PR #634.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

faircode profile has no stdin-double-read guard, unlike compare

2 participants