Skip to content

Add /notebooks/ to CODEOWNERS - #611

Merged
yakew7 merged 2 commits into
yakew7:mainfrom
raonishanth2000-hub:fix/581-notebooks-codeowners
Sep 12, 2026
Merged

yakew7 merged 2 commits into
yakew7:mainfrom
raonishanth2000-hub:fix/581-notebooks-codeowners

Conversation

@raonishanth2000-hub

Copy link
Copy Markdown

Summary

The top-level notebooks/ directory had no owner, so PRs touching any of its
8 files requested no reviewer. The per-audit entries' comment claimed to cover
"notebooks", but that only matches a notebooks folder inside an audit directory

  • this repo keeps them all in one root-level folder.

Type

  • Audit
  • Explainer
  • Bug fix
  • Other

The change

+/notebooks/ @yakew7

Owner matches the audit directories these notebooks correspond to. Placed after
them - CODEOWNERS is last-match-wins, and no later pattern can match these paths.
Also drops notebooks from the per-audit comment, which described a layout this
repo does not use.

Verification

Ran tests/test_codeowners.py's own matcher over every path in git ls-files:

before:  35 unowned  (all 8 notebooks UNOWNED)
after:   27 unowned  (all 8 -> @yakew7)

$ python -m pytest tests/ -q
385 passed, 3 skipped

Note: the issue title says 8 files and the body lists 7 - 8 is correct. Two
names in the body don't exist, and 07_intersectional_bias_audit.ipynb is
missing from it.


Closes #581

@vercel

vercel Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Someone is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown

Hey @raonishanth2000-hub, your first PR on Fair Code, that's awesome, thank you.

This project is about making AI more accountable, and contributions like yours are what keep that work going. We'll review your changes shortly.

If you haven't already, give the contributing guide a quick read: it covers how audits are structured and what we look for in a review.

And if you're finding Fair Code useful or interesting, a star on the repo genuinely helps more people find it - no pressure, just appreciated.

@github-actions

Copy link
Copy Markdown

@yakew7 @ahmdkaml - new PR touching a path you own, please review.

@yakew7
yakew7 merged commit 436b87a into yakew7:main Sep 12, 2026
1 check failed
yakew7 added a commit that referenced this pull request Sep 13, 2026
PR #611 (fix/581-notebooks-codeowners) correctly added this entry on
its own branch and verified it, but merging main into that branch
(2981a2a) silently lost the addition - main had touched the adjacent
"Project policy" comment line at the same spot (b71b2d2), and the
merge resolution kept only that change. notebooks/ (8 tracked files)
was left unowned again despite the PR being merged and closing #581.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CODEOWNERS: the top-level notebooks/ directory (8 tracked files) has zero owner

2 participants