Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the invoke polyfill into a dedicated internal header and expands support for volatile-qualified, ref-qualified, and C-style variadic member functions. Feedback identifies an incorrect noexcept specifier for member object pointer dereferencing and suggests using macros to reduce repetitive trait specializations.
…e invoke tests for C++20 member function pointers
…tions in is_invocable tests
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the invoke polyfill by moving its implementation to a dedicated internal header and significantly expanding its capabilities. The new implementation adds support for cv-qualified, ref-qualified, and C-style variadic member function pointers, as well as noexcept function types. Additionally, the configuration logic was updated to better handle MSVC language versioning and detect C++20 features. Review feedback suggests modernizing the template logic by using if constexpr or std::enable_if_t and replacing complex macros with more maintainable metaprogramming techniques.
fixes #32, fixes #33