Added support for 'reflectable'#27
Open
MikeMitterer wants to merge 5 commits into
Open
Conversation
Owner
|
Thanks for the PR, using reflectable will definitely make this library better suited for use in the browser. I spent some time experimenting with the code. One concern is I think the behaviour has changed compared to the old mirrors based version. Ideally this change will be backwards compatible so that we don't break people's existing code. I've written some extra tests, these pass on the mirrors version, but fail when run with the reflectable version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As you can see I also added two more tests plus a browser sample.
