feat: release Remote Mac KeepAwake v1.4.0 - #36
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84d49d766e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const signature = request.headers.get("x-mac-pulse-signature")?.trim().toLowerCase() ?? ""; | ||
| const bucket = await authFailureBucket(request, /^[a-zA-Z0-9._-]{1,32}$/.test(keyId) ? keyId : "invalid"); | ||
|
|
||
| const failureLimited = await authFailureLimited(bucket); |
There was a problem hiding this comment.
Enforce the authentication failure limit
Once a source reaches 30 failures, failureLimited only suppresses further writes to auth_failures; no branch rejects or delays requests because the limit was reached. An attacker can therefore continue making unlimited malformed or incorrect-signature requests, each still performing a D1 read and potentially HMAC work, so the newly advertised authentication rate limiting does not actually throttle abuse.
Useful? React with 👍 / 👎.
Summary
Local validation
Tracking
Implements the repository work for #10, #16, #33, #34, and #35. Provider-specific controlled-outage drills, broader hardware/browser matrices, and live deployment configuration remain explicit operational validation rather than being claimed by source-level tests.