Skip to content

feat: ship Mac Pulse internet monitoring and v1.3.0 hardening - #14

Merged
xudaniel merged 5 commits into
mainfrom
codex/internet-speed-monitor
Aug 21, 2026
Merged

feat: ship Mac Pulse internet monitoring and v1.3.0 hardening#14
xudaniel merged 5 commits into
mainfrom
codex/internet-speed-monitor

Conversation

@xudaniel

@xudaniel xudaniel commented Aug 21, 2026

Copy link
Copy Markdown
Owner

Summary

  • add opt-in, low-frequency Apple networkQuality sampling with cached download, upload, latency, responsiveness, and measurement timestamps
  • retain/export every health sample through additive SQLite migrations and show bilingual internet-speed history in Mac Pulse
  • complete the CI matrix for both CLIs, shell suites, dashboard build/tests, and database migration coverage
  • align the product on v1.3.0 and harden releases with reproducible archives, SHA-256 checksums, SPDX SBOMs, and GitHub attestations
  • refresh the dashboard toolchain, remove the unnecessary schema-generator CLI, and enforce a zero moderate-or-higher npm audit baseline
  • add contributor guidance, ownership, issue/PR templates, bilingual architecture docs, and a synthetic dashboard preview
  • add Dependabot, CodeQL, dependency review, repository taxonomy, milestones, and security guidance

Safety and compatibility

  • internet testing is disabled by default and rejects intervals below 30 minutes
  • older heartbeat payloads remain valid; transient speed-test failures retain the last valid cache
  • schema changes are additive and the migration test proves a pre-v1.3 sample remains readable
  • the dashboard preview is deterministic synthetic data and contains no private telemetry

Validation

  • Bash syntax and all shell suites passed
  • dashboard lint, production build, 11 tests, and legacy-data migration passed
  • release archive, SPDX SBOM, checksums, manifest, version alignment, and YAML parsing passed
  • a clean npm ci --ignore-scripts build reports zero known npm vulnerabilities
  • hosted GitHub checks are running; ShellCheck remains authoritative in CI because it is not installed locally

Story coverage

Implements #15, #16, #17, #18, #19, #20, and #21. Stories remain open until their merge/release-specific acceptance criteria are verified.

Add opt-in low-frequency networkQuality sampling, cached measurements with exact timestamps, additive D1 storage, history/CSV support, a bilingual dashboard panel, and operator documentation.
@xudaniel xudaniel changed the title feat: add remote internet speed monitoring feat: ship Mac Pulse internet monitoring and v1.3.0 hardening Aug 21, 2026
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@xudaniel
xudaniel marked this pull request as ready for review August 21, 2026 19:03
@xudaniel
xudaniel merged commit e704fd3 into main Aug 21, 2026
9 checks passed
@xudaniel
xudaniel deleted the codex/internet-speed-monitor branch August 21, 2026 19:06

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ba92e93682

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +116 to +117
const items = rows.map(mapSample).sort((left: ReturnType<typeof mapSample>, right: ReturnType<typeof mapSample>) =>
Date.parse(left.reportedAt) - Date.parse(right.reportedAt) || left.id - right.id);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Paginate in the same order used to render history

When an outage queues more than MAX_REPLAY_PER_RUN samples, each recovery run inserts a batch of old observations followed by the current sample, so IDs no longer follow reportedAt. Sorting only the returned page by reportedAt while the SQL still paginates by ORDER BY id DESC means the initial page can include old replayed samples while omitting newer observations with lower IDs; the chart and transition detector can therefore show false gaps until enough additional pages are loaded. Order and cursor the query by reported_at plus id, rather than reordering each ID-based page afterward.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants