Use raw INode* for node children - #21
Merged
Merged
Conversation
Replace std::shared_ptr<INode> with raw INode* in NodeContainer and TagNode. NodeContainer now owns child pointers and deletes them in its destructor; append() accepts INode* (with null-check and existing cycle detection preserved); children() returns a vector<INode*>. operator<< overloads were updated to take INode* and TextNode instances are allocated with new. This change simplifies the ownership model by removing shared_ptr usage for XML node children.
Delete copy ctor/assignment for DeclarationNode, TagNode and NodeContainer to enforce move-only ownership of child nodes; keep/default move semantics on NodeContainer. Wrap operator<< overloads for TagNode and NodeContainer in try/catch to delete the temporary TextNode on failure and prevent leaks. Changes improve ownership safety (avoid shallow copies) and exception-safety when appending text nodes.
Introduce convenience append overloads and improve exception safety. - include/xtrpg/xml/node/NodeContainer.hpp: add append(const std::string&) to create and append a TextNode (with RAII-style cleanup on error). - include/xtrpg/xml/node/TagNode.hpp: add template append(tagname, consumer) to construct a TagNode, allow caller configuration via a consumer, and append it safely (cleanup on exception). Includes example usage. - Qualify calls in operator<< to NodeContainer::append to avoid overload ambiguity. Enables fluent, nested XML construction and better error safety.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace std::shared_ptr with raw INode* in NodeContainer and TagNode. NodeContainer now owns child pointers and deletes them in its destructor; append() accepts INode* (with null-check and existing cycle detection preserved); children() returns a vector<INode*>. operator<< overloads were updated to take INode* and TextNode instances are allocated with new. This change simplifies the ownership model by removing shared_ptr usage for XML node children.