feat(playwright-cdp): post to Slack, and finish the rename - #24
Merged
Merged
Conversation
The skill could read a thread but not answer in it, which is where a question raised in a document actually gets resolved. slack-post.mjs replies in a thread, or posts to a channel, as the signed -in user. It is a dry run unless --send is passed: the destination is the easy thing to get wrong, a channel id in a URL says nothing about which channel it is, and a message cannot be unsent from the notifications people already received. The dry run names the workspace, the channel - or, for a DM, who it is with rather than a raw D0... id - and the thread it would land in. SKILL.md drops its blanket "read-only" claim, which is no longer true, and states when the agent may post. Slack's URL parsing, token read and API call move to slack-api.mjs so both scripts share one definition. The rename left references behind: both READMEs still linked .agents/skills/playwright-notion/, a path that no longer exists, and the profile directory and its environment variables still said notion though they now hold a Slack session too. The existing profile directory was moved rather than abandoned, so the logins survive. Verified: posted to the author's own DM and read it back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The skill could read a thread but not answer in it, which is where a question raised in a document actually gets resolved.
slack-post.mjs replies in a thread, or posts to a channel, as the signed -in user. It is a dry run unless --send is passed: the destination is the easy thing to get wrong, a channel id in a URL says nothing about which channel it is, and a message cannot be unsent from the notifications people already received. The dry run names the workspace, the channel - or, for a DM, who it is with rather than a raw D0... id - and the thread it would land in. SKILL.md drops its blanket "read-only" claim, which is no longer true, and states when the agent may post.
Slack's URL parsing, token read and API call move to slack-api.mjs so both scripts share one definition.
The rename left references behind: both READMEs still linked .agents/skills/playwright-notion/, a path that no longer exists, and the profile directory and its environment variables still said notion though they now hold a Slack session too. The existing profile directory was moved rather than abandoned, so the logins survive.
Verified: posted to the author's own DM and read it back.