Repository navigation
Move to forge v1.13.2 - #54
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves shield to forge v1.13.2 so it builds on the latest forge, for a v1.9.1 patch release.
Forge v1.13.2 adds one thing, the command envelope identity in dashboard handlers, so nothing changes for shield. Only the root go.mod requires forge directly. The nested modules get it through the root. MIGRATION.md now names v1.13.2 as the minimum.
The full lint and test targets pass, including the store tests against throwaway databases and the nested modules. Once this merges, the release workflow cuts v1.9.1.