Repository navigation
Pin nexusguard to shield v1.9.0 - #53
Merged
Merged
Conversation
The module required shield v1.8.1 and built only through the local workspace. It now requires the released v1.9.0, so a plain go get resolves the shield it was written against.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pins nexusguard to the shield release it was written for. Until now its go.mod required shield v1.8.1 and only built through the local go.work, which a
go getfrom outside the repo never sees.Now it requires
github.com/xraph/shield v1.9.0. A plaingo mod tidyworks again, so thetidy -eworkaround isn't needed any more. The rest of the go.sum churn is two golang.org/x bumps that came in with the release.With GOWORK=off in
integrations/nexusguard,go vet,go test -raceand golangci-lint all pass, with 0 issues.Once this merges,
release.ymlwithtag=integrations/nexusguard/v1.9.0cuts the module's tag.