Emit PHP 8 attributes alongside XP meta information - #195
Merged
Conversation
thekid
commented
Aug 2, 2026
| @@ -1,7 +1,5 @@ | |||
| <?php namespace lang\ast\unittest\emit; | |||
|
|
|||
| use lang\ast\emit\php\XpMeta; | |||
Member
Author
There was a problem hiding this comment.
This was an unused import.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the XP meta emitter to emit PHP 8 attributes alongside meta data. This ensures compatibility with XP 12 as well as XP 13. XP 13's class meta information no longer included annotations - its minimum required PHP version is PHP 8, which supports attributes as native syntax!
DETAIL_ANNOTATIONSfrom the meta information can be done in Drop PHP 7 support #194