Update Protos#559
Open
github-actions[bot] wants to merge 1 commit into
Open
Conversation
ApprovabilityVerdict: Needs human review Generated proto update adding significant new API surface including a bidirectional Subscribe RPC, external commit policy with symmetric key handling, and new database intent types. Security-sensitive additions and ownership by @xmtp/backend team warrant review by designated code owners. You can customize Macroscope's approvability policy. Learn more. |
fbac
approved these changes
Apr 28, 2026
d957297 to
8456af2
Compare
8456af2 to
c231d3d
Compare
Dismissing prior approval to re-evaluate c231d3d
c231d3d to
eacfb27
Compare
eacfb27 to
252bdce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated by create-pull-request
Note
Add bidirectional Subscribe RPC and new message types to MLS proto definitions
MlsApi.Subscribebidirectional streaming RPC withSubscribeRequest/SubscribeResponsemessage types, including nested V1 variants for topic mutation, ping/pong liveness, and catchup semantics inmls.pb.goandmls_grpc.pb.go.external_commit_policy.pb.go), external invite payloads (external_invite.pb.go), and group membership entries (group_membership.pb.go).AppDataUpdateDataintent message andProcessPendingSelfRemovetask variant to the database proto layer.ComponentMetadatawith anExternalCommitterPermissionsfield incomponent_permissions.pb.go.xmtpmessage_apiv1SubscribeRequest.Macroscope summarized 252bdce.