perf: skip span hashing in non-incremental builds#45
Closed
xmakro wants to merge 1 commit into
Closed
Conversation
xmakro
changed the title
xmakro
force-pushed
the
perf/skip-span-hashing-nonincr
branch
from
July 23, 2026 21:10
b5ae3c3 to
5ef05ce
Compare
xmakro
changed the title
xmakro
force-pushed
the
perf/skip-span-hashing-nonincr
branch
5 times, most recently
from
July 23, 2026 21:31
1c6f7b4 to
7871b61
Compare
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
xmakro
force-pushed
the
perf/skip-span-hashing-nonincr
branch
from
July 23, 2026 21:43
7871b61 to
8ea1e4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Span stable-hashing only matters when the hashes outlive the session, i.e. for incremental fingerprints and coverage source hashes. This PR changes it to be off otherwise, which leads to ~2% fewer instructions on non-incr full builds.