Update MountCustomize#235
Merged
Merged
Conversation
Haselnussbomber
force-pushed
the
fix-mountcustomize
branch
from
July 9, 2026 12:43
dbc86dd to
5921cb4
Compare
Haselnussbomber
force-pushed
the
fix-mountcustomize
branch
from
July 9, 2026 12:50
5921cb4 to
8004130
Compare
Contributor
✅ Validation succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The game uses the same function (
E8 ?? ?? ?? ?? 33 FF 85 C0 787.51hf2) to calculate the index as forOrnamentCustomizeGroup.Customize.It seems that they added some more columns to Scale, so the current schema was misaligned already. Using an array here, just as the game accesses these fields, is even more beneficial since Scale is ushort and CameraHeight is byte, so we would know if the arrays size got larger due to the validation. :)