WIP: Enable different entity managers for multiple log entities#44
Open
hason wants to merge 1 commit intoxiidea:masterfrom
Open
WIP: Enable different entity managers for multiple log entities#44hason wants to merge 1 commit intoxiidea:masterfrom
hason wants to merge 1 commit intoxiidea:masterfrom
Conversation
ronisaha
requested changes
Nov 28, 2019
Member
ronisaha
left a comment
ronisaha
left a comment
There was a problem hiding this comment.
We have to consider ODM also.
|
|
||
| /** | ||
| * @var ManagerRegistry | ||
| * @var \Doctrine\ORM\EntityManager |
Member
There was a problem hiding this comment.
As we also support ODM, we don't want direct dependency with ORM. You can see we remove the dependency in a earlier commit
| "php-coveralls/php-coveralls": "^2.1", | ||
| "doctrine/common": ">=2.2 <3.0" | ||
| "doctrine/common": ">=2.2 <3.0", | ||
| "doctrine/orm": "^2.2" |
Member
There was a problem hiding this comment.
No dependency should be with ORM
| { | ||
| $this->getManager()->persist($event); | ||
| $this->getManager()->flush($event); | ||
| $manager = $this->doctrine->getManagerForClass($event); |
Member
There was a problem hiding this comment.
getManagerForClass expect class name not an object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP