Repository navigation
fix(context): honor explicit zero inheritance budgets - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolveConversationRuntime conditionally forwarded inheritance limits using truthiness. An explicit numeric maxInheritTurns:0 or maxInheritedSlots:0 was therefore discarded, causing the lower-level resolver to use its default limits instead of the requested zero budget.
Forward non-nullish limits so zero keeps its intended meaning. Omitted, undefined and null values retain defaults; positive limits remain unchanged. A zero turn budget starts a new task, while a zero slot budget removes inherited conditions without changing eligible task/result lineage.
Validation: seven regressions use the real SessionMemoryStore, conversation resolver and execution-contract builder. The two zero-budget cases failed before the fix; defaults and positive-limit controls passed. Full npm test: 588 tests, 576 passed, 12 optional integration skips, 0 failures. Lint: 0 errors / 7 existing warnings. Eval: 14/14 fixtures, 2 L3 judgments pending. Independent review and parent rerun both passed all seven focused cases. No external models or business database are used.
Depends on #40 for the new-task result boundary, and transitively on #37 for the PostgreSQL HTTP acceptance repair. Merge those prerequisites first; their changes are included in this branch.