Skip to content

refactor(agent): isolate tool event presentation - #38

Open
BigDataDZ wants to merge 5 commits into
xiaour:mainfrom
BigDataDZ:codex/agent-tool-presentation
Open

BigDataDZ wants to merge 5 commits into
xiaour:mainfrom
BigDataDZ:codex/agent-tool-presentation

Conversation

@BigDataDZ

@BigDataDZ BigDataDZ commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

Tool event presentation helpers in agent.js obscure the orchestration flow. Extract their unchanged implementations into agentToolPresentation.js, reducing agent.js from 6117 to 5864 lines, and preserve the public event structure with assertions for discovery and execution events.

Refreshed against current main, preserving its conversation, semantic and answer changes. This branch includes the CI guard fix from #43; after that merges the remaining diff is limited to the helper extraction and event assertions.

Validation: 22 focused agent/prompt tests; full suite 636 passed, 12 skipped, 0 failed; architecture guard passes with seven existing warnings; eval fixtures 14/14 (two L3 judge results pending). Independent review verified the extracted bodies and remaining agent code match the latest source exactly except for import/export wiring. No architecture baseline increases.

@xiaour

xiaour commented Oct 19, 2026

Copy link
Copy Markdown
Owner

这个你再看下是否和主分支有些冲突,而且我觉得主要调整的代码,只是在agent里面将其迁移到另一个地方,是否有必要

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants