Open
Conversation
added 6 commits
September 9, 2016 21:49
…tor. Now can wrap constructor calls in a try instead of all the member calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created helper functions:
_formatNumber($number) - parses phone numbers so that user can enter a regular phone number without having to worry about getting the format the way voice wants it.
_get($path) - several methods use a curl get call, so this just standardizes the calls
_getAndParse($path, $isRead = null) - calls _get, then parses the results
_parseGetResults($xml, $isRead = null) - parses the _get results
_post($path, $options) - similar to _get. It just standardizes all the _post calls
_verifyPhoneType($type) - just checks the phone type in a function call rather than defining the array and doing the check in several places
Added arrays:
$_phoneTypes - array of phone types defined in on place rather than all over
$_serverPath - array of server paths rather than hard coding the paths in all the _post and _get calls
Added a couple more methods like archive(), and unarchive()
Grouped the method by what the methods act on (calls, voicemail, sms, all messages)