Droid: use native acp client and support default model and mode

[kohnish]

Thank you for contributing to agent-shell!

Checklist

• I agree to communicate (PR description and comments) with the author myself (not AI-generated).
• I've reviewed all code in PR myself and will vouch for its quality.
• I've read and followed the Contributing guidelines.
• I've filed a feature request/discussion for a new feature.
• I've added tests where applicable.
• I've updated documentation where necessary.
• I've run M-x checkdoc and M-x byte-compile-file.

[xenodium]

Thank you for the PR. Left you some comments to address. Could you please take a look?

Also, more importantly, have you been using this setup for some time? Is it working better for you? I'm not a droid user, so I wouldn't be a good judge of it. I'm justr trying to be mindful of anyone who's been using the current server and may experience a regression in functionality. Could you please share your experience?

[xenodium]

Using agent-shell-droid-default-reasoning-effort here will be problematic. Users may change agent-shell-droid-default-reasoning-effort but the new effort does not become active even after creating a new agent-shell session. Also setting to nil will break the command.

Let's leave this defcustom as it was and instead modify agent-shell-droid-make-client with something like:

(agent-shell--make-acp-client :command (seq-first agent-shell-droid-acp-command)
                              :command-params (append (seq-rest agent-shell-droid-acp-command)
                                                      (when agent-shell-droid-default-reasoning-effort
                                                        (list "--reasoning-effort"
                                                              agent-shell-droid-default-reasoning-effort)))
                              :environment-variables (append ...)
                              :context-buffer buffer)

[kohnish]

done!

[xenodium]

We should drop none and accept nil (default value), which signals not to include the setting at all (and document what nil does).

[kohnish]

done!

[xenodium]

We need to update install instructions also

[kohnish]

done!

[xenodium]

Thank you for the changes!

Also, more importantly, have you been using this setup for some time? Is it working better for you? I'm not a droid user, so I wouldn't be a good judge of it. I'm justr trying to be mindful of anyone who's been using the current server and may experience a regression in functionality. Could you please share your experience?

Could you comment on this please?

[kohnish]

Thank you for the changes!

Also, more importantly, have you been using this setup for some time? Is it working better for you? I'm not a droid user, so I wouldn't be a good judge of it. I'm justr trying to be mindful of anyone who's been using the current server and may experience a regression in functionality. Could you please share your experience?

Could you comment on this please?

Sorry, I missed your original comment.
I've only used the original commit for a few days and ran better than droid-acp which seems to get stuck for whatever reasons.
I'll test drive with reasoning-effort set tomorrow and let you know.

[xenodium]

Thank you! I'll wait for your signal to merge.