Fix invalid markup generated for dropdown in Bootstrap 4#100
Open
nathan-osman wants to merge 1 commit intoxcash:masterfrom
Open
Fix invalid markup generated for dropdown in Bootstrap 4#100nathan-osman wants to merge 1 commit intoxcash:masterfrom
nathan-osman wants to merge 1 commit intoxcash:masterfrom
Conversation
When run in Bootstrap 4, the plugin creates <a> elements for the dropdown. However, this is invalid markup, as the href attribute is required for the <a> element. The result of this omission is that the text color is incorrect in many themes and the cursor is not a pointer. This pull request fixes the oversight.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When run in Bootstrap 4, the plugin creates
<a>elements for the dropdown. However, this is invalid markup, as thehrefattribute is required for the<a>element.The result of this omission is that the text color is incorrect in many themes and the cursor is not a pointer:
This pull request fixes the oversight.