Repository navigation
Skip IPv6 ranges in geo files instead of crashing at startup - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a file in
geo/has an IPv6 line, BotGate exits at startup with:load_geo_filestores the ranges inarray('L')and an IPv6 address doesn't fit. The listeners only bind IPv4, so this skips IPv6 ranges and logs one warning per file. The IP2Location page the docs point to can generate IPv6 lists, so it's an easy file to end up with.I added
tests/test_geo.py, which fails without the change. The full suite passes here.Thanks for BotGate.