Repository navigation
fix(server): name the app in the lockfile note from the path as given - #250
Merged
Merged
Conversation
On Windows the note named the app from the path read back from the file URI, which is spelled differently from the folder the user gave, so test/cli.js did not find the app's folder in it. The note now walks the given path made absolute, as the folder walk does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012jSfzj1UNFUHV9YmmbjLg4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #249, which was merged before this fix landed on its branch. Its Windows CI job fails in
test/cli.js.On Windows, the missing-
Gemfile.locknote named the app from the path read back from the file URI. That path is spelled differently from the folder the user gave, so the test didn't find the app's folder in the note. The note now walks the given path made absolute (std::path::absolute, no URI round trip, no symlink resolution), as the folder walk does. The assertion also prints stderr now, so another failure shows what the note said.Tests: 1005 Rust tests and
bun test/cli.jspass on Linux. The Windows job on this PR is the check that matters.Generated by Claude Code