Skip to content

fix(server): name the app in the lockfile note from the path as given - #250

Merged
x-ror merged 1 commit into
mainfrom
fix/lockfile-note-windows
Nov 14, 2026
Merged

x-ror merged 1 commit into
mainfrom
fix/lockfile-note-windows

Conversation

@x-ror

@x-ror x-ror commented Nov 14, 2026

Copy link
Copy Markdown
Owner

Follow-up to #249, which was merged before this fix landed on its branch. Its Windows CI job fails in test/cli.js.

On Windows, the missing-Gemfile.lock note named the app from the path read back from the file URI. That path is spelled differently from the folder the user gave, so the test didn't find the app's folder in the note. The note now walks the given path made absolute (std::path::absolute, no URI round trip, no symlink resolution), as the folder walk does. The assertion also prints stderr now, so another failure shows what the note said.

Tests: 1005 Rust tests and bun test/cli.js pass on Linux. The Windows job on this PR is the check that matters.


Generated by Claude Code

On Windows the note named the app from the path read back from the
file URI, which is spelled differently from the folder the user gave,
so test/cli.js did not find the app's folder in it. The note now walks
the given path made absolute, as the folder walk does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012jSfzj1UNFUHV9YmmbjLg4
@x-ror x-ror self-assigned this Nov 14, 2026
@x-ror
x-ror merged commit 53ca91d into main Nov 14, 2026
15 checks passed
@x-ror
x-ror deleted the fix/lockfile-note-windows branch November 14, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants