Repository navigation
refactor(tls): move the OpenSSL bindings into their own package, pkg/tls - #506
Merged
Merged
Conversation
tls.odin and the platform root hooks move out of pkg/runtime unchanged, plus one constant (SSL_ERROR_SSL). fetch_tls, net and the https server import `openssl "lava:pkg/tls"`. The bindings have no runtime or JSC dependency, so a JS-free client can share them; Larva's pkg/http does (x-ror/larva#76), and the move is made here too so the next sync does not hit a modify/rename conflict. No behavior change. Checked: CI's Checks job targets (make check on all three targets, bun run js:check, make check-md, make check-actions), make build, and an https fetch() through lava eval. No tests: paused for this phase. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Needed by Larva's HTTP client to tell a peer that closes without close_notify from a TLS failure (x-ror/larva#76); added here so pkg/tls stays identical in both repos. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
tls.odinand the platform root hooks move out ofpkg/runtimeintopkg/tls, unchanged apart from one added constant (SSL_ERROR_SSL).fetch_tls,netand the https server importopenssl "lava:pkg/tls".CLAUDE.md's layering table anddocs/ARCHITECTURE.md§3.5 name the package.Why
The bindings have no runtime or JSC dependency, so a JS-free client can share them. Larva's new HTTP client does (x-ror/larva#76). Making the same move here keeps the next Lava→Larva sync from hitting a modify/rename conflict.
Checked
No behavior change intended. CI's Checks job targets pass locally (
make checkon all three targets,bun run js:check,make check-md,make check-actions),make buildsucceeds, and an httpsfetch()throughlava evalreturns the page.pkg/tlsand the three runtime files that use it are byte-identical to Larva's. No tests, on the owner's instruction for this phase.🤖 Generated with Claude Code