Repository navigation
fix(ci): bun-format scripts/fmt-if.mjs; drop the shim's comments - #74
Merged
Merged
Conversation
- scripts/fmt-if.mjs was never run through `bun fmt`, so `make check-js` failed on master after the Lava sync (#73). Formatted; same fix as in Lava. - pkg/html/shim/larva_html.c: the owner removed the explanatory comments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
odinfmt puts a space before the brace of the list in lazy_builtins_test.odin, and the script test's pattern required none, so make check-js failed on it once the first fix let the format check through. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the CI failure on master after the Lava sync (#73), from two causes:
scripts/fmt-if.mjswas never run throughbun fmt, so the format check inmake check-jsfailed.STATIC_EAGER :: [?]string {with a space, andscripts/check-js-graph.test.mjslooked for it without one, so the script tests failed once the format check passed.Also
pkg/html/shim/larva_html.c: the owner removed the explanatory comments.Checked locally, all exit 0:
bun run js:check(314 pass),make check,make check-md,make check-actions— the whole "Checks" job. The shim is clean under clang-format. Lava gets the same two fixes.🤖 Generated with Claude Code