Skip to content

fix(ci): bun-format scripts/fmt-if.mjs; drop the shim's comments - #74

Merged
x-ror merged 2 commits into
masterfrom
fix/fmt-if-format
Nov 18, 2026
Merged

x-ror merged 2 commits into
masterfrom
fix/fmt-if-format

Conversation

@x-ror

@x-ror x-ror commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Fixes the CI failure on master after the Lava sync (#73), from two causes:

  • scripts/fmt-if.mjs was never run through bun fmt, so the format check in make check-js failed.
  • odinfmt writes STATIC_EAGER :: [?]string { with a space, and scripts/check-js-graph.test.mjs looked for it without one, so the script tests failed once the format check passed.

Also pkg/html/shim/larva_html.c: the owner removed the explanatory comments.

Checked locally, all exit 0: bun run js:check (314 pass), make check, make check-md, make check-actions — the whole "Checks" job. The shim is clean under clang-format. Lava gets the same two fixes.

🤖 Generated with Claude Code

x-ror and others added 2 commits November 18, 2026 23:08
- scripts/fmt-if.mjs was never run through `bun fmt`, so `make check-js`
  failed on master after the Lava sync (#73). Formatted; same fix as in Lava.
- pkg/html/shim/larva_html.c: the owner removed the explanatory comments.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
odinfmt puts a space before the brace of the list in lazy_builtins_test.odin,
and the script test's pattern required none, so make check-js failed on it
once the first fix let the format check through.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@x-ror
x-ror merged commit 38a2e43 into master Nov 18, 2026
5 checks passed
@x-ror
x-ror deleted the fix/fmt-if-format branch November 18, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant