Repository navigation
build(fmt): braces on every if, a blank line around every if; lexbor in .vscode - #72
Merged
Merged
Conversation
…in .vscode - CLAUDE.md §4: `if` always has braces on their own lines, and a blank line before and after every `if` statement unless it opens or closes a block or a case. Applied by `make fmt` to Larva's own code (pkg/html, the shim): odinfmt convert_do, clang-format InsertBraces, then scripts/fmt-if.mjs for what neither formatter does. Same script and rules as x-ror/lava#504. - .vscode/c_cpp_properties.json: lexbor's headers (.deps/lexbor/include) and picohttpparser on the include path, so the C/C++ extension stops reporting "#include errors detected" in the shim. Run scripts/build-lexbor.sh once to create .deps. Formatting only. Rebuilt and checked `lava html --scripts --select` by hand; odin check passes on linux, windows and darwin targets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ifalways has braces, on their own lines: noif x do y, noif x {y}.ifstatement, unless it opens or closes a block or acase. A comment directly above belongs to theif.Both rules are in
CLAUDE.md§4 and applied bymake fmtto Larva's own code (pkg/html, the shim): odinfmtconvert_do, clang-formatInsertBraces, thenscripts/fmt-if.mjsfor what neither formatter does. Same script and rules as x-ror/lava#504; Lava-synced files are left until the next sync brings that formatting over..vscode/c_cpp_properties.jsonputs lexbor's headers (.deps/lexbor/include) and picohttpparser on the include path, so the C/C++ extension stops reporting "#include errors detected" in the shim..depsexists afterscripts/build-lexbor.shhas run once.Checked
Formatting only. Rebuilt and checked
lava html --scripts --selectby hand;odin checkpasses on linux, windows and darwin targets; a secondmake fmtchanges nothing. No tests: paused for this phase.🤖 Generated with Claude Code