Skip to content

merge: sync lava master (0f7715a) - #66

Merged
x-ror merged 3 commits into
masterfrom
sync/lava
Nov 18, 2026
Merged

x-ror merged 3 commits into
masterfrom
sync/lava

Conversation

@x-ror

@x-ror x-ror commented Nov 18, 2026

Copy link
Copy Markdown
Owner

Sync of x-ror/lava master (0f7715a). Brings x-ror/lava#503: the Node-only modules (sqlite, fs, os, net, http, https, dns, tty) are out of the default build behind LAVA_NODE_MODULES, and the CI test and mutation jobs run only from workflow_dispatch.

One conflict, .github/workflows/ci.yml: both sides added workflow_dispatch. Kept once, with both comments. Consequence worth knowing: the Sync from Lava workflow starts CI through workflow_dispatch, so a sync PR it opens still runs the paused jobs.

Not run: any test suite or gate, on the owner's instruction for this phase. make check passes. Larva tests that load fs or dns in a page (the reap tests) will fail on the default build until they are run with NODE_MODULES=1 or rewritten.

Merge with "Create a merge commit", not squash.

🤖 Generated with Claude Code

x-ror and others added 3 commits November 18, 2026 20:57
LAVA_NODE_MODULES (#config, default false) decides whether node:sqlite, node:fs,
node:os, node:net, node:http, node:https, node:dns and node:tty are part of the
build. With it off their bindings objects are never created and the loader's
compile refuses their ids, so `require` of one is MODULE_NOT_FOUND.
`NODE_MODULES=1 ./scripts/build.sh` builds them back in unchanged; nothing is
deleted.

CI: the test and mutation jobs run only from workflow_dispatch while tests are
paused. Type-check and lint still run on every push and PR.

Not done here: libsqlite3 is still linked (pkg/std/sqlite is still imported),
the excluded modules' sources are still embedded, and node:crypto stays in
because it loads at start-up.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
build(runtime): take the Node-only modules out of the default build
Brings x-ror/lava up to 0f7715a:

- bde0ab5 build(runtime): take the Node-only modules out of the default build (x-ror/lava#503)

One conflict, .github/workflows/ci.yml: both sides added workflow_dispatch.
Kept once, with both comments. Note the consequence: the Sync from Lava workflow
starts CI through workflow_dispatch, so a sync PR it opens still runs the paused
test and mutation jobs.

No test suite was run; `make check` passes.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@x-ror
x-ror merged commit d2f2b06 into master Nov 18, 2026
5 checks passed
@x-ror
x-ror deleted the sync/lava branch November 18, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant