Repository navigation
Conversation
LAVA_NODE_MODULES (#config, default false) decides whether node:sqlite, node:fs, node:os, node:net, node:http, node:https, node:dns and node:tty are part of the build. With it off their bindings objects are never created and the loader's compile refuses their ids, so `require` of one is MODULE_NOT_FOUND. `NODE_MODULES=1 ./scripts/build.sh` builds them back in unchanged; nothing is deleted. CI: the test and mutation jobs run only from workflow_dispatch while tests are paused. Type-check and lint still run on every push and PR. Not done here: libsqlite3 is still linked (pkg/std/sqlite is still imported), the excluded modules' sources are still embedded, and node:crypto stays in because it loads at start-up. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
build(runtime): take the Node-only modules out of the default build
Brings x-ror/lava up to 0f7715a: - bde0ab5 build(runtime): take the Node-only modules out of the default build (x-ror/lava#503) One conflict, .github/workflows/ci.yml: both sides added workflow_dispatch. Kept once, with both comments. Note the consequence: the Sync from Lava workflow starts CI through workflow_dispatch, so a sync PR it opens still runs the paused test and mutation jobs. No test suite was run; `make check` passes. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync of x-ror/lava
master(0f7715a). Brings x-ror/lava#503: the Node-only modules (sqlite,fs,os,net,http,https,dns,tty) are out of the default build behindLAVA_NODE_MODULES, and the CI test and mutation jobs run only fromworkflow_dispatch.One conflict,
.github/workflows/ci.yml: both sides addedworkflow_dispatch. Kept once, with both comments. Consequence worth knowing: the Sync from Lava workflow starts CI throughworkflow_dispatch, so a sync PR it opens still runs the paused jobs.Not run: any test suite or gate, on the owner's instruction for this phase.
make checkpasses. Larva tests that loadfsordnsin a page (the reap tests) will fail on the default build until they are run withNODE_MODULES=1or rewritten.Merge with "Create a merge commit", not squash.
🤖 Generated with Claude Code