fix(workspace): complete session grouping and repair UI regressions - #93
Conversation
Add native project and session-tab grouping with persistent membership, collapsed state, and transfers that retain terminal ownership. Repair dark Quick Launch rendering and the confirmed terminal, search, editor, SSH, and shortcut regressions from the recent PR review. Co-authored-by: Codex <noreply@openai.com>
Thank you for opening a pull request. Check these requirements while it is awaiting review.
|
Summary
GitHub Project
PR Type
Validation
Status: passed
Command:
xcodebuild -project mac/zshell.xcodeproj -scheme zshell -configuration Debug -destination 'platform=macOS,arch=arm64' -derivedDataPath <temporary> build;codesign --verify --deep --strict --verbose=2 <Debug app>Result: Final arm64 Debug build and strict signature verification passed. No new source warnings; Debug identity and version unchanged.
Status: passed
Command:
python3 mac/tests/test_prompt_selection.py;python3 mac/tests/test_file_content_search.py;python3 mac/tests/test_project_file_search.py;python3 mac/tests/test_terminal_links.py;python3 mac/tests/test_ghostty_link_position.py;cargo test --locked --manifest-path mac/Vendor/alacritty-bridge/Cargo.tomlResult: Real PTY/zsh 11 tests, grep 5 tests, project file search 13 assertions, link classification 4 tests, Ghostty 15 in-memory engine scenarios, and Rust 35 tests passed. Additional local harnesses passed 40 grouping checks, 33 offscreen AppKit behavior checks, 9 dynamic-color checks, editor undo checks, and randomized UTF16 indexing checks. These harnesses do not establish complete visible GUI acceptance.
Status: passed
Command:
bun run typecheck && bun run buildin an isolated copy of the current website;git diff --check;bash .github/scripts/check-repository-hygiene.shResult: Website type checking, build and 38-page prerendering passed after the documentation updates. Diff and repository hygiene checks passed. Temporary build/test artifacts were removed.
Status: passed
Command: Launch baseline and integrated Debug apps and exercise Quick Launch through native desktop automation.
Result: Reproduced the original dark background, duplicated rows, narrow editor and invalid SSH port issues. Observed the integrated native sidebar/tab strip, corrected dark empty state and 480-point editor; verified the saved command entry in actual application storage.
Status: not run
Reason: The desktop automation service subsequently returned repeated timeouts. Complete visible drag/drop, cross-window PTY transfers, restart recovery, both-backend smoke tests, system IME, notification delivery, settings import/export and external SSH acceptance remain pending. Existing model/engine checks cover only their stated scope.
Risk and Rollback
Related Issue
None
AI Attribution