Skip to content

fix(compact): resolve unresolved review findings and harden parsing#12

Merged
wynxing merged 1 commit into
codex/taskstate-compact-prfrom
fork-pr-270-1776130742
Apr 14, 2026
Merged

fix(compact): resolve unresolved review findings and harden parsing#12
wynxing merged 1 commit into
codex/taskstate-compact-prfrom
fork-pr-270-1776130742

Conversation

@fennoai

@fennoai fennoai Bot commented Apr 14, 2026

Copy link
Copy Markdown

Requested by @Yumiue

Summary

  • Wire and through config loader persistence.
  • Harden compact summary parsing by rejecting invalid list field types instead of silently dropping values.
  • Add loader tests for new compact keys and simplify loader test setup via shared helper.
  • Keep behavior-preserving simplification in provider assembly iteration.

- wire compact extended fields through loader persistence
- reject invalid compact task_state list value types to avoid silent data loss
- add loader/load-save tests for new compact keys
- simplify loader provider assembly and loader tests helper

Generated with [codeagent](https://github.com/qbox/codeagent)
Co-authored-by: Yumiue <188874804+Yumiue@users.noreply.github.com>
@wynxing wynxing merged commit 903f898 into codex/taskstate-compact-pr Apr 14, 2026
1 check passed
@fennoai fennoai Bot deleted the fork-pr-270-1776130742 branch April 14, 2026 03:20
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 74.60317% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/runtime/compact_generator.go 63.15% 7 Missing and 7 partials ⚠️
internal/config/loader.go 92.00% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

wynxing pushed a commit that referenced this pull request Apr 15, 2026
fix(runtime): preserve ErrMaxLoopReached sentinel on loop-limit exit
wynxing pushed a commit that referenced this pull request Apr 15, 2026
…er-fix

test(tui): improve multimodal and session-switch coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants