Skip to content

fix(compact): address review findings and simplify parsing/rendering#10

Merged
wynxing merged 1 commit into
codex/taskstate-compact-prfrom
fork-pr-270-1776130742
Apr 14, 2026
Merged

fix(compact): address review findings and simplify parsing/rendering#10
wynxing merged 1 commit into
codex/taskstate-compact-prfrom
fork-pr-270-1776130742

Conversation

@fennoai

@fennoai fennoai Bot commented Apr 14, 2026

Copy link
Copy Markdown

Requested by @Yumiue

Summary

  • Addressed unresolved review comments in compact/task-state changes.
  • Escaped TaskState line breaks before bullet-style prompt rendering to prevent prompt-shape injection.
  • Aligned compact JSON candidate selection with strict decoder validation and added fallback regression test.
  • Applied low-risk simplification refactors in touched files and re-ran build/tests.

- escape TaskState line breaks before prompt rendering
- use strict decoder during compact JSON candidate scan
- add regressions for injection-safe rendering and strict-candidate fallback
- apply low-risk simplifications in touched files

Generated with [codeagent](https://github.com/qbox/codeagent)
Co-authored-by: Yumiue <188874804+Yumiue@users.noreply.github.com>
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@wynxing wynxing merged commit f1cbdb1 into codex/taskstate-compact-pr Apr 14, 2026
1 check passed
@fennoai fennoai Bot deleted the fork-pr-270-1776130742 branch April 14, 2026 02:20
wynxing pushed a commit that referenced this pull request Apr 15, 2026
fix(runtime): address unresolved review findings and simplify paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants