Skip to content

chore(pullfrog): model・effort を org 共通設定から継承する - #38

Merged
wwwyo merged 1 commit into
mainfrom
wwwyo/pullfrog-inherit-org-model
Oct 24, 2026
Merged

wwwyo merged 1 commit into
mainfrom
wwwyo/pullfrog-inherit-org-model

Conversation

@wwwyo

@wwwyo wwwyo commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

Blast Radius

低 — Pullfrog の設定 script だけを変更する。Pullfrog 側は反映済み(この repo の model・effort は org の値を継承している)。挙動は org の設定(opencode-go/beam-free、effort 1)で決まる。

What

.github/pullfrog.config.sh での model(と effort 1)の固定をやめ、org 共通の設定を継承させる。この repo だけ別の値にしたいときは、ここで pf_set すれば上書きできる。

Background

Pullfrog の model・effort は、wwwyo/dotfiles の .github/pullfrog.org.config.sh で org 共通に管理するようにした(https://github.com/wwwyo/dotfiles/pull/122)。free 枠の model が消えても、org で 1 か所直せば全 repo が追従する。repo 側の script が固定したままだと、script を再実行したときに古い model へ戻ってしまうため、継承に揃える。

QA

pullfrog config list --repo で、この repo の model が [org] として継承されていることを確認した。script の変更は 1〜2 行の置き換えだけ。

https://claude.ai/code/session_01EUgMLcfukUoucoQ5DWyw4u

Summary by CodeRabbit

  • Chores
    • Automation settings now inherit the organization’s default model and effort values rather than using repository-specific settings. This may change which defaults apply to automated workflows; no changes to end-user features or app behavior are included in this update.

@wwwyo wwwyo self-assigned this Oct 23, 2026
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 96908ba and bd3e309.

📒 Files selected for processing: 1
  • .github/pullfrog.config.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The Pullfrog configuration script now unsets the repository-level model and effort settings instead of assigning repository-specific values. Both settings can inherit organization defaults.

Changes: Pullfrog configuration

Layer / File(s) Summary
Inherit model and effort settings
.github/pullfrog.config.sh
The script unsets model and effort instead of assigning repository-specific values.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to bd3e3

No actionable merge-blocking risk was identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: inheriting the model and effort settings from the organization-wide configuration.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — reviewed PR #38 (1 file, 1 commit) which removes the repo-pinned Pullfrog model/effort in favor of inheriting org defaults.

  • .github/pullfrog.config.sh: replace pf_set model 'opencode-go/minimax-m3.1-flash-free' and pf_set effort '1' with pf_unset model / pf_unset effort, with an override hint in the comment. Mechanism matches Pullfrog's documented "unset to inherit" behavior and the org config's own convergence pattern; the removed free model had already disappeared and broke Pullfrog across repos.

No P0/P1/P2 findings. One informational note: inheritance assumes the org backend actually provides model/effort (PR body states this was verified via pullfrog config list --repo showing [org]); the referenced dotfiles PR #122 (org SSOT change) is still open, so confirm the org backend is applied before merging or inheritance falls through to the platform default.

Pullfrog  | View workflow run | Using beam-free | 𝕏

@wwwyo
wwwyo marked this pull request as ready for review October 24, 2026 02:53
@wwwyo
wwwyo merged commit 66618a1 into main Oct 24, 2026
8 checks passed
@wwwyo
wwwyo deleted the wwwyo/pullfrog-inherit-org-model branch October 24, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant