Skip to content

fix(install): skip hidden entries in the skills directory - #38

Merged
wwwyo merged 1 commit into
mainfrom
claude/project-thread-egj65n
Nov 22, 2026
Merged

wwwyo merged 1 commit into
mainfrom
claude/project-thread-egj65n

Conversation

@wwwyo

@wwwyo wwwyo commented Nov 21, 2026 •

Copy link
Copy Markdown
Owner

Requested by yuito · project thread

Why

wwwyo/skills keeps a Codex plugin manifest at .agents/skills/.codex-plugin. CheckSkills treated it as a skill name, so the scheduled Skillctrl Update failed with skill names must be plain directory names (https://github.com/wwwyo/skills/actions/runs/44877340147).

What

  • install.Hidden marks dot-prefixed entries as tooling, not skills.
  • CheckSkills and the import step skip them, so they are neither rejected nor linked into .claude/skills, and are left in place.
  • Test: TestCheckSkillsIgnoresHiddenEntries.

Verification

  • go test ./... and go vet ./... pass.
  • Built this branch and ran skillctrl --adapter git update on a clean checkout of wwwyo/skills main: exits 0 with 5 updates (agent-browser, unslop merged; e2e, learn, prototype conflicted). .codex-plugin stays and gets no .claude/skills link.

Generated by Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Hidden entries are now ignored when validating skill directories, so hidden folders alongside skills no longer cause validation failures.
    • Hidden entries are excluded from import reconciliation, preventing them from being treated as skills or affecting the set of skills being synchronized.

wwwyo/skills keeps a Codex plugin manifest at .agents/skills/.codex-plugin.
CheckSkills treated it as a skill name and refused it, so every update in
that repository failed with "skill names must be plain directory names".
Skill names never start with a dot, so hidden entries are now left in place
instead of being validated, imported, or linked into .claude/skills.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LjGAVfjGzeFtSKuWJaPWHY
@wwwyo wwwyo self-assigned this Nov 21, 2026
@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The installer now skips dot-prefixed entries during skill validation and excludes them from import reconciliation. A test verifies that a hidden plugin manifest directory does not cause skill validation to fail.

Changes: Hidden entry handling

Layer / File(s) Summary
Hidden entry validation
internal/install/install.go, internal/install/install_test.go
Hidden identifies names beginning with a dot. CheckSkills skips those entries. A test checks that a hidden .codex-plugin directory containing plugin.json is accepted.
Hidden entry import
internal/install/install.go
Import excludes hidden entries from the existing and imported skill name sets used in reconciliation.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: Minimal · up to 6ea32

Dot-prefixed entries such as .codex-plugin in the skills directory are now ignored during validation and import instead of causing a failure. Regular skills keep their existing validation. The risk of merging is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "fix(install): skip hidden entries in the skills directory" matches the main change. The PR adds install.Hidden, makes CheckSkills skip dot-prefixed entries instead of validating them, and m…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "fix(install): skip hidden entries in the skills directory" matches the main change. The PR adds install.Hidden, makes CheckSkills skip dot-prefixed entries instead of validating them, and makes Import exclude them. The PR objectives describe the same problem: CheckSkills rejected .agents/skills/.codex-plugin as an invalid skill name. The title is specific and concise, and it follows the conventional commit style.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 47f86b03-3990-4c63-9fca-a6f8bd3cd488
Commits

Reviewing files that changed from the base of the PR and between d98a684 and 6ea3233.

Files selected for processing: 2

  • internal/install/install.go
  • internal/install/install_test.go

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound. A single Hidden predicate is applied at the two places that enumerate the skills directory for validation and import, so tooling directories such as .codex-plugin are neither rejected nor linked.

Reviewed changes: I read the full diff and the surrounding CheckSkills and Import code. I also checked the other ReadDir call sites for skills directories.

  • install.Hidden: treats dot-prefixed entries as tooling rather than skills.
  • CheckSkills: skips hidden entries before name validation, the symlink check and the walk. A hidden entry is never imported or written through, so the symlink-isolation invariant is not weakened.
  • Import: skips hidden entries in both the before and after listings. They never reach names, so they get no .claude/skills link, are not removed, and are left in place. Replacement only touches existing/<name> for names in names.
  • Test: TestCheckSkillsIgnoresHiddenEntries covers the .codex-plugin case from the failing scheduled update.
  • Other call sites: skillctrl list already filters through upstream.Name, and the adapter staging directory is separate. Neither is affected.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@wwwyo
wwwyo merged commit a580cf0 into main Nov 22, 2026
9 checks passed
@wwwyo
wwwyo deleted the claude/project-thread-egj65n branch November 22, 2026 00:00
wwwyo added a commit to wwwyo/skills that referenced this pull request Nov 22, 2026
11/15 の design plugin 追加で .agents/skills/.codex-plugin ができてから、
skillctrl update が「skill names must be plain directory names」で落ち、
土曜の Skillctrl Update が止まっていた(wwwyo/skillctrl#38 で修正)。


Claude-Session: https://claude.ai/code/session_01LjGAVfjGzeFtSKuWJaPWHY

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants