Repository navigation
fix(install): skip hidden entries in the skills directory - #38
Conversation
wwwyo/skills keeps a Codex plugin manifest at .agents/skills/.codex-plugin. CheckSkills treated it as a skill name and refused it, so every update in that repository failed with "skill names must be plain directory names". Skill names never start with a dot, so hidden entries are now left in place instead of being validated, imported, or linked into .claude/skills. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LjGAVfjGzeFtSKuWJaPWHY
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
✅ No new issues found.
Approach: sound. A single Hidden predicate is applied at the two places that enumerate the skills directory for validation and import, so tooling directories such as .codex-plugin are neither rejected nor linked.
Reviewed changes: I read the full diff and the surrounding CheckSkills and Import code. I also checked the other ReadDir call sites for skills directories.
install.Hidden: treats dot-prefixed entries as tooling rather than skills.CheckSkills: skips hidden entries before name validation, the symlink check and the walk. A hidden entry is never imported or written through, so the symlink-isolation invariant is not weakened.Import: skips hidden entries in both thebeforeandafterlistings. They never reachnames, so they get no.claude/skillslink, are not removed, and are left in place. Replacement only touchesexisting/<name>for names innames.- Test:
TestCheckSkillsIgnoresHiddenEntriescovers the.codex-plugincase from the failing scheduled update. - Other call sites:
skillctrl listalready filters throughupstream.Name, and the adapter staging directory is separate. Neither is affected.
claude-sonnet-5-5 | 𝕏
11/15 の design plugin 追加で .agents/skills/.codex-plugin ができてから、 skillctrl update が「skill names must be plain directory names」で落ち、 土曜の Skillctrl Update が止まっていた(wwwyo/skillctrl#38 で修正)。 Claude-Session: https://claude.ai/code/session_01LjGAVfjGzeFtSKuWJaPWHY Co-authored-by: Claude <noreply@anthropic.com>

Requested by yuito · project thread
Why
wwwyo/skills keeps a Codex plugin manifest at
.agents/skills/.codex-plugin.CheckSkillstreated it as a skill name, so the scheduled Skillctrl Update failed withskill names must be plain directory names(https://github.com/wwwyo/skills/actions/runs/44877340147).What
install.Hiddenmarks dot-prefixed entries as tooling, not skills.CheckSkillsand the import step skip them, so they are neither rejected nor linked into.claude/skills, and are left in place.TestCheckSkillsIgnoresHiddenEntries.Verification
go test ./...andgo vet ./...pass.skillctrl --adapter git updateon a clean checkout of wwwyo/skills main: exits 0 with 5 updates (agent-browser, unslop merged; e2e, learn, prototype conflicted)..codex-pluginstays and gets no.claude/skillslink.Generated by Claude Code
Summary by CodeRabbit