Skip to content

chore(pullfrog): model・effort を org 共通設定から継承する - #4

Merged
wwwyo merged 1 commit into
mainfrom
wwwyo/pullfrog-inherit-org-model
Oct 24, 2026
Merged

wwwyo merged 1 commit into
mainfrom
wwwyo/pullfrog-inherit-org-model

Conversation

@wwwyo

@wwwyo wwwyo commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

Blast Radius

低 — Pullfrog の設定 script だけを変更する。Pullfrog 側は反映済み(この repo の model・effort は org の値を継承している)。挙動は org の設定(opencode-go/beam-free、effort 1)で決まる。

What

.github/pullfrog.config.sh での model(と effort 1)の固定をやめ、org 共通の設定を継承させる。この repo だけ別の値にしたいときは、ここで pf_set すれば上書きできる。

Background

Pullfrog の model・effort は、wwwyo/dotfiles の .github/pullfrog.org.config.sh で org 共通に管理するようにした(https://github.com/wwwyo/dotfiles/pull/122)。free 枠の model が消えても、org で 1 か所直せば全 repo が追従する。repo 側の script が固定したままだと、script を再実行したときに古い model へ戻ってしまうため、継承に揃える。

QA

pullfrog config list --repo で、この repo の model が [org] として継承されていることを確認した。script の変更は 1〜2 行の置き換えだけ。

https://claude.ai/code/session_01EUgMLcfukUoucoQ5DWyw4u

Summary by CodeRabbit

  • Configuration
    • AI processing now follows the organization’s default model and effort settings. Other configuration settings remain unchanged. This may affect which model is used and how much effort is applied, depending on the organization’s defaults. No other user-facing changes are included in this update.

@wwwyo wwwyo self-assigned this Oct 23, 2026
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2ac44f4f-f837-4da7-bcf0-7153fdef7e78
📥 Commits

Reviewing files that changed from the base of the PR and between b27a049 and 2329c38.

📒 Files selected for processing: 1
  • .github/pullfrog.config.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The Pullfrog configuration now unsets model and effort instead of assigning explicit values. Both settings inherit the organization defaults.

Changes: Pullfrog configuration defaults

Layer / File(s) Summary
Inherit organization defaults
.github/pullfrog.config.sh
The script unsets model and effort instead of assigning explicit values.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 2329c

The change removes stale repository-specific defaults and restores organization-managed Pullfrog settings.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title is in Japanese and reads roughly "chore(pullfrog): inherit model and effort from the org-wide settings". It matches the main change: the diff unsets the fixed model and effort in .github/pul…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title is in Japanese and reads roughly "chore(pullfrog): inherit model and effort from the org-wide settings". It matches the main change: the diff unsets the fixed model and effort in .github/pullfrog.config.sh so both inherit the organization defaults, as the PR objectives describe. The title names the file scope (pullfrog) and the change type (chore), and it states the specific behavior change.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Reviewed .github/pullfrog.config.sh (1 file, 1 commit) — the PR replaces pinned model/effort settings with pf_unset so pi-vim inherits the org-level defaults.

  • Inherit org model/effort: pf_set model 'opencode-go/minimax-m3.1-flash-free' and pf_set effort '1' become pf_unset model / pf_unset effort, restoring inheritance of opencode-go/beam-free at effort 1. Other repo settings remain pinned.

Pullfrog  | View workflow run | Using beam-free | 𝕏

@wwwyo
wwwyo marked this pull request as ready for review October 24, 2026 02:53
@wwwyo
wwwyo merged commit de8ed92 into main Oct 24, 2026
5 checks passed
@wwwyo
wwwyo deleted the wwwyo/pullfrog-inherit-org-model branch October 24, 2026 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant