Repository navigation
chore(pullfrog): org 共通設定を fudoki-hensansitu にも当てる - #134
Conversation
fudoki の repo を fudoki-hensansitu org へ移したため、--org wwwyo の model・ effort・instructions が届かなくなった。ORGS に並べた owner ごとに同じ設定を 当てる。BYOK key も owner ごとなので、新しい owner には secret set が要る。 Claude-Session: https://claude.ai/code/session_01JttqtHPCUeLzn6SU5WFB44
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 52 minutes. View limit details
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Configure settings for each organization .github/pullfrog.org.config.sh |
The script loops over wwwyo and fudoki-hensansitu. Setting helpers and instructions configuration use the current organization in the loop. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Possibly related PRs
- wwwyo/dotfiles#117: Changes the Pullfrog model in repository settings. This PR also configures the same model as an organization default.
- wwwyo/dotfiles#122: Establishes organization-level model and effort defaults. This PR extends that configuration to a second organization.
Merge Risk: 
Minimal · up to 068f0
-
The configuration change is ready to merge with no identified blocking risk.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passed-
Full details: Title check
-
Explanation
The title names the main change: the shared Pullfrog org settings (org 共通設定) now also apply to fudoki-hensansitu. The raw summary confirms the script runs the setting, unset, instructions, and remaining-settings steps for both wwwyo and fudoki-hensansitu instead of hardcoding wwwyo. The title uses the conventional chore(pullfrog): prefix and is specific enough for a teammate scanning history. The title is in Japanese, which matches the PR's language, and it does not include a file list or vague wording.
-
-
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
There was a problem hiding this comment.
Important
org スコープが複数 owner に広がったのに AGENTS.md の監査手順が --org wwwyo のまま残っており、fudoki-hensansitu の実効値の drift が見逃される可能性があります。
Reviewed changes
この run では PR #134 の 1 ファイル(.github/pullfrog.org.config.sh)をレビューしました。org 共通の Pullfrog defaults を wwwyo に加えて fudoki-hensansitu にも当てるため、単一 org の --org wwwyo を ORGS ループに変更した chore です。
- Org loop 化:
ORGS=(wwwyo fudoki-hensansitu)を導入し、pf_set/pf_unsetが--org "$ORG"を動的スコープで参照するように変更 - 全設定の反復適用: model・effort・
xrepo.briefの unset・instructions heredoc をfor ORG in ...の中へ移動 - 監査ヒントの一般化:
--org wwwyoを--org <org>に
⚠️ AGENTS.md の org スコープ記述が古いまま
AGENTS.md:121 は org defaults のスコープを (`--org wwwyo` scope) と記述していますが、PR 後は ORGS の全 owner に適用されます。この記述に従って pullfrog config list --org wwwyo のみを監査すると、fudoki-hensansitu の実効値(model/effort/instructions)の drift が検出できません — まさに本 PR が解消しようとした問題の再発経路です。parenthetical を multi-owner スコープ(例: (`--org <each of ORGS>`: wwwyo, fudoki-hensansitu))に更新し、owner ごとに監査する旨を追記してください。
Technical details
# Stale org-scope description in AGENTS.md
## Affected sites
- AGENTS.md:121 — "org 共通の defaults ... (`--org wwwyo` scope)が正本"
## Required outcome
- The documented audit scope must cover every owner in `ORGS` (wwwyo, fudoki-hensansitu), so a future audit following the doc does not silently skip fudoki-hensansitu.
## Suggested approach
- Update the parenthetical to `(`--org <each of ORGS>`: wwwyo, fudoki-hensansitu)` and note that `pullfrog config list --org <org>` must be run per owner (not just `--repo` + a single `--org`).
## Open questions for the human
- Should the ORGS list itself be documented in AGENTS.md, or stay SSOT in the script?beam-free | 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This run re-reviewed PR #134 after commit 29665ae landed. The incremental change is a documentation update to AGENTS.md:121 that resolves the prior review's P2 finding about the stale org-scope description. The prior P3 thread on pf_unset xrepo.brief (.github/pullfrog.org.config.sh:37) was resolved as a sound design decision based on the author's rationale and independent verification.
- AGENTS.md org-scope doc fix: Updated the parenthetical from
(`--org wwwyo` scope)to describe the per-owner--orgscope overORGS(wwwyo, fudoki-hensansitu) and clarified that the audit must runpullfrog config list --org <org>per repo owner.
beam-free | 𝕏

概要
fudoki を
fudoki-hensansituorg へ移したので、--org wwwyoの model・effort・instructions が届かなくなった。ORGS=(wwwyo fudoki-hensansitu)の owner ごとに同じ設定を当てる。確認
pullfrog config list --org wwwyoと--org fudoki-hensansituの両方で modelopencode-go/beam-free・effort 1・instructions が[org]になったfudoki-hensansitu/fudokiの repo 設定もこれを受け継いでいるOPENCODE_API_KEYはfudoki-hensansituにも別に入れたhttps://claude.ai/code/session_01JttqtHPCUeLzn6SU5WFB44
Summary by CodeRabbit