Skip to content

chore(pullfrog): org 共通設定を fudoki-hensansitu にも当てる - #134

Merged
wwwyo merged 2 commits into
mainfrom
chore/pullfrog-org-defaults-for-fudoki-hensansitu
Oct 25, 2026
Merged

wwwyo merged 2 commits into
mainfrom
chore/pullfrog-org-defaults-for-fudoki-hensansitu

Conversation

@wwwyo

@wwwyo wwwyo commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner

概要

fudoki を fudoki-hensansitu org へ移したので、--org wwwyo の model・effort・instructions が届かなくなった。ORGS=(wwwyo fudoki-hensansitu) の owner ごとに同じ設定を当てる。

確認

  • script を実行し、pullfrog config list --org wwwyo と --org fudoki-hensansitu の両方で model opencode-go/beam-free・effort 1・instructions が [org] になった
  • fudoki-hensansitu/fudoki の repo 設定もこれを受け継いでいる
  • BYOK の OPENCODE_API_KEY は fudoki-hensansitu にも別に入れた

https://claude.ai/code/session_01JttqtHPCUeLzn6SU5WFB44

Summary by CodeRabbit

  • Chores
    • Updated organization configuration to apply shared settings consistently across both configured organizations, including instructions and remaining settings. This keeps the configuration behavior aligned between them.

fudoki の repo を fudoki-hensansitu org へ移したため、--org wwwyo の model・
effort・instructions が届かなくなった。ORGS に並べた owner ごとに同じ設定を
当てる。BYOK key も owner ごとなので、新しい owner には secret set が要る。

Claude-Session: https://claude.ai/code/session_01JttqtHPCUeLzn6SU5WFB44
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 52 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a16b674e-3d7c-4875-9de0-54e3026723f4
Commits

Reviewing files that changed from the base of the PR and between 068f078 and 29665ae.

Files selected for processing: 1
  • AGENTS.md

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 55d280e3-8651-45ef-85da-124b5947a178
Commits

Reviewing files that changed from the base of the PR and between 30b3b5d and 068f078.

Files selected for processing: 1
  • .github/pullfrog.org.config.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The Pullfrog organization configuration script now applies its shared settings and instructions to both wwwyo and fudoki-hensansitu.

Changes: Organization settings

Layer / File(s) Summary
Configure settings for each organization
.github/pullfrog.org.config.sh
The script loops over wwwyo and fudoki-hensansitu. Setting helpers and instructions configuration use the current organization in the loop.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

  • wwwyo/dotfiles#117: Changes the Pullfrog model in repository settings. This PR also configures the same model as an organization default.
  • wwwyo/dotfiles#122: Establishes organization-level model and effort defaults. This PR extends that configuration to a second organization.
Merge Risk: Minimal · up to 068f0

The configuration change is ready to merge with no identified blocking risk.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: the shared Pullfrog org settings (org 共通設定) now also apply to fudoki-hensansitu. The raw summary confirms the script runs the setting, unset, instructions, and remaini…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the shared Pullfrog org settings (org 共通設定) now also apply to fudoki-hensansitu. The raw summary confirms the script runs the setting, unset, instructions, and remaining-settings steps for both wwwyo and fudoki-hensansitu instead of hardcoding wwwyo. The title uses the conventional chore(pullfrog): prefix and is specific enough for a teammate scanning history. The title is in Japanese, which matches the PR's language, and it does not include a file list or vague wording.

Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

org スコープが複数 owner に広がったのに AGENTS.md の監査手順が --org wwwyo のまま残っており、fudoki-hensansitu の実効値の drift が見逃される可能性があります。

Reviewed changes

この run では PR #134 の 1 ファイル(.github/pullfrog.org.config.sh)をレビューしました。org 共通の Pullfrog defaults を wwwyo に加えて fudoki-hensansitu にも当てるため、単一 org の --org wwwyo を ORGS ループに変更した chore です。

  • Org loop 化: ORGS=(wwwyo fudoki-hensansitu) を導入し、pf_set/pf_unset が --org "$ORG" を動的スコープで参照するように変更
  • 全設定の反復適用: model・effort・xrepo.brief の unset・instructions heredoc を for ORG in ... の中へ移動
  • 監査ヒントの一般化: --org wwwyo を --org <org> に

⚠️ AGENTS.md の org スコープ記述が古いまま

AGENTS.md:121 は org defaults のスコープを (`--org wwwyo` scope) と記述していますが、PR 後は ORGS の全 owner に適用されます。この記述に従って pullfrog config list --org wwwyo のみを監査すると、fudoki-hensansitu の実効値(model/effort/instructions)の drift が検出できません — まさに本 PR が解消しようとした問題の再発経路です。parenthetical を multi-owner スコープ(例: (`--org <each of ORGS>`: wwwyo, fudoki-hensansitu))に更新し、owner ごとに監査する旨を追記してください。

Technical details
# Stale org-scope description in AGENTS.md

## Affected sites
- AGENTS.md:121 — "org 共通の defaults ... (`--org wwwyo` scope)が正本"

## Required outcome
- The documented audit scope must cover every owner in `ORGS` (wwwyo, fudoki-hensansitu), so a future audit following the doc does not silently skip fudoki-hensansitu.

## Suggested approach
- Update the parenthetical to `(`--org <each of ORGS>`: wwwyo, fudoki-hensansitu)` and note that `pullfrog config list --org <org>` must be run per owner (not just `--repo` + a single `--org`).

## Open questions for the human
- Should the ORGS list itself be documented in AGENTS.md, or stay SSOT in the script?

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using beam-free | 𝕏

Comment thread .github/pullfrog.org.config.sh Resolved

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

This run re-reviewed PR #134 after commit 29665ae landed. The incremental change is a documentation update to AGENTS.md:121 that resolves the prior review's P2 finding about the stale org-scope description. The prior P3 thread on pf_unset xrepo.brief (.github/pullfrog.org.config.sh:37) was resolved as a sound design decision based on the author's rationale and independent verification.

  • AGENTS.md org-scope doc fix: Updated the parenthetical from (`--org wwwyo` scope) to describe the per-owner --org scope over ORGS (wwwyo, fudoki-hensansitu) and clarified that the audit must run pullfrog config list --org <org> per repo owner.

Pullfrog  | View workflow run | Using beam-free | 𝕏

@wwwyo
wwwyo merged commit a66d60a into main Oct 25, 2026
9 checks passed
@wwwyo
wwwyo deleted the chore/pullfrog-org-defaults-for-fudoki-hensansitu branch October 25, 2026 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant